Re: [PATCH v2] ASoC: tas2781: Add Calibration Kcontrols for Chromebook

[kernel test robot <lkp@intel.com>]

Hi Shenghao,

kernel test robot noticed the following build warnings:

[auto build test WARNING on broonie-sound/for-next]
[also build test WARNING on next-20240902]
[cannot apply to tiwai-sound/for-next tiwai-sound/for-linus linus/master v6.11-rc6]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shenghao-Ding/ASoC-tas2781-Add-Calibration-Kcontrols-for-Chromebook/20240902-142152
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link:    https://lore.kernel.org/r/20240902062029.983-1-shenghao-ding%40ti.com
patch subject: [PATCH v2] ASoC: tas2781: Add Calibration Kcontrols for Chromebook
config: alpha-randconfig-r073-20240902 (https://download.01.org/0day-ci/archive/20240903/202409030627.SFdj22Xs-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409030627.SFdj22Xs-lkp@intel.com/

smatch warnings:
sound/soc/codecs/tas2781-i2c.c:452 sngl_calib_start() warn: inconsistent indenting

vim +452 sound/soc/codecs/tas2781-i2c.c

   425	
   426	static void sngl_calib_start(struct tasdevice_priv *tas_priv, int i,
   427		int *reg, unsigned char *dat)
   428	{
   429		struct tasdevice *tasdev = tas_priv->tasdevice;
   430		struct bulk_reg_val *p = tasdev[i].cali_data_backup;
   431		const int sum = ARRAY_SIZE(tas2781_cali_start_reg);
   432		int j;
   433	
   434		if (p == NULL)
   435			return;
   436	
   437		/* Store the current setting from the chip */
   438		for (j = 0; j < sum; j++) {
   439			if (p[j].val_len == 1) {
   440				if (p[j].is_locked)
   441					tasdevice_dev_write(tas_priv, i,
   442						TAS2781_TEST_UNLOCK_REG,
   443						TAS2781_TEST_PAGE_UNLOCK);
   444				tasdevice_dev_read(tas_priv, i, p[j].reg,
   445					(int *)&p[j].val[0]);
   446			} else {
   447				switch (p[j].reg) {
   448				case 0:
   449				if (!reg[0])
   450					continue;
   451				p[j].reg = reg[0];
 > 452					break;
   453				case TAS2781_PRM_PLT_FLAG_REG:
   454				p[j].reg = reg[1];
   455					break;
   456				case TAS2781_PRM_SINEGAIN_REG:
   457				p[j].reg = reg[2];
   458					break;
   459				case TAS2781_PRM_SINEGAIN2_REG:
   460				p[j].reg = reg[3];
   461					break;
   462				}
   463				tasdevice_dev_bulk_read(tas_priv, i, p[j].reg,
   464					p[j].val, 4);
   465			}
   466		}
   467	
   468		/* Update the setting for calibration */
   469		for (j = 0; j < sum - 2; j++) {
   470			if (p[j].val_len == 1) {
   471				if (p[j].is_locked)
   472					tasdevice_dev_write(tas_priv, i,
   473						TAS2781_TEST_UNLOCK_REG,
   474						TAS2781_TEST_PAGE_UNLOCK);
   475				tasdevice_dev_write(tas_priv, i, p[j].reg,
   476					tas2781_cali_start_reg[j].val[0]);
   477			} else {
   478				if (!p[j].reg)
   479					continue;
   480				tasdevice_dev_bulk_write(tas_priv, i, p[j].reg,
   481					(unsigned char *)
   482					tas2781_cali_start_reg[j].val, 4);
   483			}
   484		}
   485	
   486		tasdevice_dev_bulk_write(tas_priv, i, p[j].reg, &dat[1], 4);
   487		tasdevice_dev_bulk_write(tas_priv, i, p[j + 1].reg, &dat[5], 4);
   488	}
   489	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki