From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53129D32D8B for ; Tue, 12 Nov 2024 10:40:45 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D189B231C; Tue, 12 Nov 2024 11:40:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D189B231C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1731408042; bh=UTB7rna8C2SmXb+CbI0L9/7fDGZHifqbzEw4rtLnFu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=k+PWdniQBQb0JG2bOLp8qHx2pfCh9Fgc3J2Xbro5tt26mWlMCrc2++1bBhRF9Du4i FreVUzHkp2KQD2uQ6SvYDSpZ5IvyB1onPTpt4LdLvkfzZPIeGoz7OEvjFGmkFEZi6f aC2Y/0Vle68RdG1GUATkhbUG9DOgmF5Q8fJFy2bY= Received: by alsa1.perex.cz (Postfix, from userid 50401) id DA62EF806D7; Tue, 12 Nov 2024 11:38:31 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6EC37F806D6; Tue, 12 Nov 2024 11:38:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B0A60F8064F; Tue, 12 Nov 2024 11:38:26 +0100 (CET) Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A7BC7F805C1 for ; Tue, 12 Nov 2024 11:38:24 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A7BC7F805C1 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ZU+52KJQ Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 080E8A4196E; Tue, 12 Nov 2024 10:36:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4428EC4CED7; Tue, 12 Nov 2024 10:38:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731407903; bh=UTB7rna8C2SmXb+CbI0L9/7fDGZHifqbzEw4rtLnFu0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZU+52KJQQgkrYNI5B61TS9q6rdaiMEtzK6rre/DUOajJoqzkdzViES6v+9ZAFoG9x OJUWBnLO+0V3xsxLjmTeSJ3fsFarvyOVzUc7jBsdgNTAz0fuoDn0p4cfZ5YlysB4R3 Nxx/Xmu85BQuEO/pKp0zwDw6IHXisWdm26KAP53O37/7zm0eRmWdBQCnYoAQUEhdI4 KH5reP0zX7ftooBREJJzyQ9mEWbTB3AZLqEBU6JSiGfqlh1bhmQQDYKNnogEhOs8Ed WLpaZ9M0t552MBi7sTMIfjxIWlOd5epNP6hRZyQ66Da0BSYZgQL0NkJxnZ0xdoewwd RRJD1CuqqCH5Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Luo Yifan , Mark Brown , Sasha Levin , olivier.moysan@foss.st.com, arnaud.pouliquen@foss.st.com, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.4 3/5] ASoC: stm: Prevent potential division by zero in stm32_sai_mclk_round_rate() Date: Tue, 12 Nov 2024 05:38:13 -0500 Message-ID: <20241112103817.1654333-3-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241112103817.1654333-1-sashal@kernel.org> References: <20241112103817.1654333-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.285 Content-Transfer-Encoding: 8bit Message-ID-Hash: O2EWTCLS5WKGOFENLWWX4HGFSY34QSP2 X-Message-ID-Hash: O2EWTCLS5WKGOFENLWWX4HGFSY34QSP2 X-MailFrom: sashal@kernel.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Luo Yifan [ Upstream commit 63c1c87993e0e5bb11bced3d8224446a2bc62338 ] This patch checks if div is less than or equal to zero (div <= 0). If div is zero or negative, the function returns -EINVAL, ensuring the division operation (*prate / div) is safe to perform. Signed-off-by: Luo Yifan Link: https://patch.msgid.link/20241106014654.206860-1-luoyifan@cmss.chinamobile.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/stm/stm32_sai_sub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/stm/stm32_sai_sub.c b/sound/soc/stm/stm32_sai_sub.c index 7e965848796c3..b7dc9d3192597 100644 --- a/sound/soc/stm/stm32_sai_sub.c +++ b/sound/soc/stm/stm32_sai_sub.c @@ -379,8 +379,8 @@ static long stm32_sai_mclk_round_rate(struct clk_hw *hw, unsigned long rate, int div; div = stm32_sai_get_clk_div(sai, *prate, rate); - if (div < 0) - return div; + if (div <= 0) + return -EINVAL; mclk->freq = *prate / div; -- 2.43.0