alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks
@ 2025-12-11 15:22 Jussi Laako
  2025-12-11 15:22 ` [PATCH 2/3] ALSA: usb-audio: Reorder USB mode selection quirk Jussi Laako
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Jussi Laako @ 2025-12-11 15:22 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, Jussi Laako

Maintenance patch for native DSD support.

Add set of missing device and vendor quirks; TEAC, Esoteric, Luxman and
Musical Fidelity.

Signed-off-by: Jussi Laako <jussi@sonarnerd.net>
---
 sound/usb/quirks.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 61bd61ffb1b2..94a8fdc9c6d3 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2230,6 +2230,12 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 	DEVICE_FLG(0x0644, 0x806b, /* TEAC UD-701 */
 		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
 		   QUIRK_FLAG_IFACE_DELAY),
+	DEVICE_FLG(0x0644, 0x807d, /* TEAC UD-507 */
+		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
+		   QUIRK_FLAG_IFACE_DELAY),
+	DEVICE_FLG(0x0644, 0x806c, /* Esoteric XD */
+		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
+		   QUIRK_FLAG_IFACE_DELAY),
 	DEVICE_FLG(0x06f8, 0xb000, /* Hercules DJ Console (Windows Edition) */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x06f8, 0xd002, /* Hercules DJ Console (Macintosh Edition) */
@@ -2388,6 +2394,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_CTL_MSG_DELAY_1M),
 	DEVICE_FLG(0x30be, 0x0101, /* Schiit Hel */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
+	DEVICE_FLG(0x3255, 0x0000, /* Luxman D-10X */
+		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY),
 	DEVICE_FLG(0x339b, 0x3a07, /* Synaptics HONOR USB-C HEADSET */
 		   QUIRK_FLAG_MIXER_PLAYBACK_MIN_MUTE),
 	DEVICE_FLG(0x413c, 0xa506, /* Dell AE515 sound bar */
@@ -2431,6 +2439,8 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_DSD_RAW),
 	VENDOR_FLG(0x2622, /* IAG Limited devices */
 		   QUIRK_FLAG_DSD_RAW),
+	VENDOR_FLG(0x2772, /* Musical Fidelity devices */
+		   QUIRK_FLAG_DSD_RAW),
 	VENDOR_FLG(0x278b, /* Rotel? */
 		   QUIRK_FLAG_DSD_RAW),
 	VENDOR_FLG(0x292b, /* Gustard/Ess based devices */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] ALSA: usb-audio: Reorder USB mode selection quirk
  2025-12-11 15:22 [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Jussi Laako
@ 2025-12-11 15:22 ` Jussi Laako
  2025-12-11 15:22 ` [PATCH 3/3] ALSA: usb-audio: Do not expose PCM and DSD on same altsetting unless DoP Jussi Laako
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Jussi Laako @ 2025-12-11 15:22 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, Jussi Laako

When using mode selection quirk, apply the quirk before rate setting.
Also apply this quirk on certain newer ITF interface devices.

Signed-off-by: Jussi Laako <jussi@sonarnerd.net>
---
 sound/usb/endpoint.c | 6 +++---
 sound/usb/quirks.c   | 8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index cc15624ecaff..8f9313857ee9 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -1481,15 +1481,15 @@ int snd_usb_endpoint_prepare(struct snd_usb_audio *chip,
 			return err;
 	}
 
-	err = snd_usb_init_pitch(chip, ep->cur_audiofmt);
+	err = snd_usb_select_mode_quirk(chip, ep->cur_audiofmt);
 	if (err < 0)
 		return err;
 
-	err = init_sample_rate(chip, ep);
+	err = snd_usb_init_pitch(chip, ep->cur_audiofmt);
 	if (err < 0)
 		return err;
 
-	err = snd_usb_select_mode_quirk(chip, ep->cur_audiofmt);
+	err = init_sample_rate(chip, ep);
 	if (err < 0)
 		return err;
 
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 94a8fdc9c6d3..f38330b095e9 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -2221,7 +2221,7 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_IFACE_DELAY),
 	DEVICE_FLG(0x0644, 0x8044, /* Esoteric D-05X */
 		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
-		   QUIRK_FLAG_IFACE_DELAY),
+		   QUIRK_FLAG_IFACE_DELAY | QUIRK_FLAG_FORCE_IFACE_RESET),
 	DEVICE_FLG(0x0644, 0x804a, /* TEAC UD-301 */
 		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
 		   QUIRK_FLAG_IFACE_DELAY),
@@ -2229,13 +2229,13 @@ static const struct usb_audio_quirk_flags_table quirk_flags_table[] = {
 		   QUIRK_FLAG_FORCE_IFACE_RESET),
 	DEVICE_FLG(0x0644, 0x806b, /* TEAC UD-701 */
 		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
-		   QUIRK_FLAG_IFACE_DELAY),
+		   QUIRK_FLAG_IFACE_DELAY | QUIRK_FLAG_FORCE_IFACE_RESET),
 	DEVICE_FLG(0x0644, 0x807d, /* TEAC UD-507 */
 		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
-		   QUIRK_FLAG_IFACE_DELAY),
+		   QUIRK_FLAG_IFACE_DELAY | QUIRK_FLAG_FORCE_IFACE_RESET),
 	DEVICE_FLG(0x0644, 0x806c, /* Esoteric XD */
 		   QUIRK_FLAG_ITF_USB_DSD_DAC | QUIRK_FLAG_CTL_MSG_DELAY |
-		   QUIRK_FLAG_IFACE_DELAY),
+		   QUIRK_FLAG_IFACE_DELAY | QUIRK_FLAG_FORCE_IFACE_RESET),
 	DEVICE_FLG(0x06f8, 0xb000, /* Hercules DJ Console (Windows Edition) */
 		   QUIRK_FLAG_IGNORE_CTL_ERROR),
 	DEVICE_FLG(0x06f8, 0xd002, /* Hercules DJ Console (Macintosh Edition) */
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] ALSA: usb-audio: Do not expose PCM and DSD on same altsetting unless DoP
  2025-12-11 15:22 [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Jussi Laako
  2025-12-11 15:22 ` [PATCH 2/3] ALSA: usb-audio: Reorder USB mode selection quirk Jussi Laako
@ 2025-12-11 15:22 ` Jussi Laako
  2025-12-13  9:33 ` [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Takashi Iwai
  2025-12-17  2:04 ` otiscavin3
  3 siblings, 0 replies; 5+ messages in thread
From: Jussi Laako @ 2025-12-11 15:22 UTC (permalink / raw)
  To: alsa-devel; +Cc: tiwai, Jussi Laako

Do not expose DSD altsetting as a PCM one, even if the descriptor claims
it to be PCM instead of special format.

Signed-off-by: Jussi Laako <jussi@sonarnerd.net>
---
 sound/usb/format.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/usb/format.c b/sound/usb/format.c
index ec95a063beb1..64cfe4a9d8cd 100644
--- a/sound/usb/format.c
+++ b/sound/usb/format.c
@@ -34,6 +34,7 @@ static u64 parse_audio_format_i_type(struct snd_usb_audio *chip,
 {
 	int sample_width, sample_bytes;
 	u64 pcm_formats = 0;
+	u64 dsd_formats = 0;
 
 	switch (fp->protocol) {
 	case UAC_VERSION_1:
@@ -154,7 +155,9 @@ static u64 parse_audio_format_i_type(struct snd_usb_audio *chip,
 			 fp->iface, fp->altsetting, format);
 	}
 
-	pcm_formats |= snd_usb_interface_dsd_format_quirks(chip, fp, sample_bytes);
+	dsd_formats |= snd_usb_interface_dsd_format_quirks(chip, fp, sample_bytes);
+	if (dsd_formats && !fp->dsd_dop)
+		pcm_formats = dsd_formats;
 
 	return pcm_formats;
 }
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks
  2025-12-11 15:22 [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Jussi Laako
  2025-12-11 15:22 ` [PATCH 2/3] ALSA: usb-audio: Reorder USB mode selection quirk Jussi Laako
  2025-12-11 15:22 ` [PATCH 3/3] ALSA: usb-audio: Do not expose PCM and DSD on same altsetting unless DoP Jussi Laako
@ 2025-12-13  9:33 ` Takashi Iwai
  2025-12-17  2:04 ` otiscavin3
  3 siblings, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2025-12-13  9:33 UTC (permalink / raw)
  To: Jussi Laako; +Cc: alsa-devel

On Thu, 11 Dec 2025 16:22:21 +0100,
Jussi Laako wrote:
> 
> Maintenance patch for native DSD support.
> 
> Add set of missing device and vendor quirks; TEAC, Esoteric, Luxman and
> Musical Fidelity.
> 
> Signed-off-by: Jussi Laako <jussi@sonarnerd.net>

Applied all three patches now.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks
  2025-12-11 15:22 [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Jussi Laako
                   ` (2 preceding siblings ...)
  2025-12-13  9:33 ` [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Takashi Iwai
@ 2025-12-17  2:04 ` otiscavin3
  3 siblings, 0 replies; 5+ messages in thread
From: otiscavin3 @ 2025-12-17  2:04 UTC (permalink / raw)
  To: alsa-devel

This patch updates the quirk table / handling logic for USB audio devices that support native DSD (Direct Stream Digital).

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2025-12-17  2:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-11 15:22 [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Jussi Laako
2025-12-11 15:22 ` [PATCH 2/3] ALSA: usb-audio: Reorder USB mode selection quirk Jussi Laako
2025-12-11 15:22 ` [PATCH 3/3] ALSA: usb-audio: Do not expose PCM and DSD on same altsetting unless DoP Jussi Laako
2025-12-13  9:33 ` [PATCH 1/3] ALSA: usb-audio: Update for native DSD support quirks Takashi Iwai
2025-12-17  2:04 ` otiscavin3

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).