From: <jack.yu@realtek.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>
Cc: <alsa-devel@alsa-project.org>, <lars@metafoo.de>,
<flove@realtek.com>, <oder_chiou@realtek.com>,
<shumingf@realtek.com>, <derek.fang@realtek.com>,
Jack Yu <jack.yu@realtek.com>
Subject: [PATCH v2 2/2] ASoC: rt1320-sdw: Add an approach to get new hardware advance gain
Date: Thu, 2 Apr 2026 14:46:01 +0800 [thread overview]
Message-ID: <20260402064601.1799013-2-jack.yu@realtek.com> (raw)
In-Reply-To: <20260402064601.1799013-1-jack.yu@realtek.com>
From: Jack Yu <jack.yu@realtek.com>
Add an approach to get new hardware advance gain,
and if there is no advance gain with this approach,
we can still get advance gain with original method.
Signed-off-by: Jack Yu <jack.yu@realtek.com>
---
sound/soc/codecs/rt1320-sdw.c | 21 +++++++++++++++++++--
sound/soc/codecs/rt1320-sdw.h | 13 +++++++++++++
2 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/rt1320-sdw.c b/sound/soc/codecs/rt1320-sdw.c
index a76d3212d741..3692d04568bb 100644
--- a/sound/soc/codecs/rt1320-sdw.c
+++ b/sound/soc/codecs/rt1320-sdw.c
@@ -1014,13 +1014,30 @@ static void rt1320_set_advancemode(struct rt1320_sdw_priv *rt1320)
struct device *dev = &rt1320->sdw_slave->dev;
struct rt1320_datafixpoint r0_data[2];
unsigned short l_advancegain, r_advancegain;
+ FwPara_Get_HwSwGain audDriverDataHwSwGain;
+ unsigned int HwAdvGain;
int ret;
+ /* Get new hardware advance gain by ID 1300 */
+ rt1320_fw_param_protocol(rt1320, RT1320_GET_PARAM, 1300,
+ &audDriverDataHwSwGain, sizeof(audDriverDataHwSwGain));
+ HwAdvGain = audDriverDataHwSwGain.HwAdvGain;
+ dev_dbg(dev, "%s, HwAdvGain=%d\n", __func__, HwAdvGain);
+ dev_dbg(dev, "%s, HwBasGain=%d\n", __func__, audDriverDataHwSwGain.HwBasGain);
+ dev_dbg(dev, "%s, SwAdvGain=%d\n", __func__, audDriverDataHwSwGain.SwAdvGain);
+ dev_dbg(dev, "%s, SwBasGain=%d\n", __func__, audDriverDataHwSwGain.SwBasGain);
+
/* Get advance gain/r0 */
rt1320_fw_param_protocol(rt1320, RT1320_GET_PARAM, 6, &r0_data[0], sizeof(struct rt1320_datafixpoint));
rt1320_fw_param_protocol(rt1320, RT1320_GET_PARAM, 7, &r0_data[1], sizeof(struct rt1320_datafixpoint));
- l_advancegain = r0_data[0].advancegain;
- r_advancegain = r0_data[1].advancegain;
+
+ if (HwAdvGain != 0) {
+ l_advancegain = HwAdvGain & 0xffff;
+ r_advancegain = (HwAdvGain >> 16) & 0xffff;
+ } else {
+ l_advancegain = r0_data[0].advancegain;
+ r_advancegain = r0_data[1].advancegain;
+ }
dev_dbg(dev, "%s, LR advanceGain=0x%x 0x%x\n", __func__, l_advancegain, r_advancegain);
/* set R0 and enable protection by SetParameter id 6, 7 */
diff --git a/sound/soc/codecs/rt1320-sdw.h b/sound/soc/codecs/rt1320-sdw.h
index 4a1d3fc4c8ee..a7b573883dd0 100644
--- a/sound/soc/codecs/rt1320-sdw.h
+++ b/sound/soc/codecs/rt1320-sdw.h
@@ -121,6 +121,19 @@ struct rt1320_datafixpoint {
int invrs;
};
+typedef struct FwPara_HwSwGain {
+ unsigned int SwAdvGain;
+ unsigned int SwBasGain;
+ unsigned int HwAdvGain;
+ unsigned int HwBasGain;
+ unsigned int reserve0;
+ unsigned int reserve1;
+ unsigned int reserve2;
+ unsigned int reserve3;
+ unsigned int reserve4;
+ unsigned int reserve5;
+} __attribute__((packed)) FwPara_Get_HwSwGain;
+
struct rt1320_paramcmd {
unsigned char moudleid;
unsigned char commandtype;
--
2.53.0
next prev parent reply other threads:[~2026-04-02 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 6:46 [PATCH v2 1/2] ASoC: rt1320-sdw: kcontrol for brown-out feature update jack.yu
2026-04-02 6:46 ` jack.yu [this message]
2026-04-02 12:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260402064601.1799013-2-jack.yu@realtek.com \
--to=jack.yu@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox