Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: stable@vger.kernel.org
Cc: Sasha Levin <sashal@kernel.org>,
	perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
	gregkh@linuxfoundation.org, pzqqt88198@gmail.com,
	Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 5.10.y v1] ALSA: usb-audio: Evaluate packsize caps at the right place
Date: Mon, 10 Aug 2026 19:57:41 -0400	[thread overview]
Message-ID: <20260810234738.0002-1-sashal@kernel.org> (raw)
In-Reply-To: <20260809074320.1407-1-pzqqt88198@gmail.com>

> diff --git a/sound/usb/pcm.c b/sound/usb/pcm.c
> @@ -953,6 +953,13 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream *substream)
> +	subs->data_endpoint->packsize[0] = min(
> +		subs->data_endpoint->packsize[0],
> +		subs->data_endpoint->maxframesize);

Moving the cap into snd_usb_pcm_prepare() is the right call for 5.10 - that
tree never computes ep->maxframesize inside snd_usb_endpoint_set_params(), so
there is nowhere in that function to move it to - but nothing in the changelog
says that. Please send a v2 that spells the relocation out in the commit
message, since the diff no longer matches upstream.

Two other things before I can take it:

- The Signed-off-by needs your real name; a handle does not satisfy the DCO.
- An ack from Takashi on the 5.10 placement, he's already on Cc.

-- 
Thanks,
Sasha

      reply	other threads:[~2026-08-10 23:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-09  7:43 [PATCH 5.10.y v1] ALSA: usb-audio: Evaluate packsize caps at the right place pzqqt88198
2026-08-10 23:57 ` Sasha Levin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260810234738.0002-1-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=perex@perex.cz \
    --cc=pzqqt88198@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox