From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org,
Thierry Escande <thierry.escande@collabora.com>,
tiwai@suse.de, liam.r.girdwood@linux.intel.com,
broonie@kernel.org, jarkko.nikula@linux.intel.com,
andriy.shevchenko@linux.intel.com
Subject: Re: [PATCH 5/7] ASoC: ts3a227e: add acpi table
Date: Fri, 8 Sep 2017 08:30:37 -0500 [thread overview]
Message-ID: <20292830-6f66-a67e-8030-a7eaf808c3fe@linux.intel.com> (raw)
In-Reply-To: <20170908132705.GH3053@localhost>
>> +#ifdef CONFIG_ACPI
>> +static struct acpi_device_id ts3a227e_acpi_match[] = {
>> + { "104C227E", 0 },
>> + {},
>> +};
>> +MODULE_DEVICE_TABLE(acpi, ts3a227e_acpi_match);
>> +#endif
>
> so this is not present for non ACPI system,... fine
>
>> +
>> static struct i2c_driver ts3a227e_driver = {
>> .driver = {
>> .name = "ts3a227e",
>> .pm = &ts3a227e_pm,
>> .of_match_table = of_match_ptr(ts3a227e_of_match),
>> + .acpi_match_table = ACPI_PTR(ts3a227e_acpi_match),
>
> but then this would give compiler error on those systems as .acpi_match_table is
> defined in driver core... can you compile this on non acpi and check
This is not any different from what is done for other codecs.
static struct i2c_driver rt5677_i2c_driver = {
.driver = {
.name = "rt5677",
.of_match_table = rt5677_of_match,
.acpi_match_table = ACPI_PTR(rt5677_acpi_match),
},
And the 0day checks did not report any issues, probably because the
pre-processor takes the table out when CONFIG_ACPI is not enabled:
#define ACPI_PTR(_ptr) (NULL)
so no change...
next prev parent reply other threads:[~2017-09-08 13:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-08 5:13 [PATCH 0/7] BYT/CHT clocks/max98090 updates Pierre-Louis Bossart
2017-09-08 5:13 ` [PATCH 1/7] ASoC: max98090: reduce verbosity on PLL unlock Pierre-Louis Bossart
2017-09-19 13:45 ` Applied "ASoC: max98090: reduce verbosity on PLL unlock" to the asoc tree Mark Brown
2017-09-08 5:13 ` [PATCH 2/7] ASoC: Intel: cht_bsw_max98090: Fix I2S config + unused code Pierre-Louis Bossart
2017-09-08 5:13 ` [PATCH 3/7] ASoC: Intel: cht_bsw_max98090: add support for Baytrail Pierre-Louis Bossart
2017-09-18 7:17 ` Andy Shevchenko
2017-09-18 17:14 ` Pierre-Louis Bossart
2017-09-19 9:51 ` Andy Shevchenko
2017-09-19 13:45 ` Applied "ASoC: Intel: cht_bsw_max98090: add support for Baytrail" to the asoc tree Mark Brown
2017-09-08 5:13 ` [PATCH 4/7] ASoC: Intel: atom: use cht_bsw_max98090 for Baytrail Chromebooks Pierre-Louis Bossart
2017-09-08 5:13 ` [PATCH 5/7] ASoC: ts3a227e: add acpi table Pierre-Louis Bossart
2017-09-08 13:27 ` Vinod Koul
2017-09-08 13:30 ` Pierre-Louis Bossart [this message]
2017-09-12 14:54 ` Mark Brown
2017-09-18 3:36 ` Vinod Koul
2017-09-08 5:13 ` [PATCH 6/7] ASoc: Intel: cht_bsw_max98090_ti: Fix jack initialization Pierre-Louis Bossart
2017-09-19 13:45 ` Applied "ASoC: Intel: cht_bsw_max98090_ti: Fix jack initialization" to the asoc tree Mark Brown
2017-09-08 5:13 ` [PATCH 7/7] ASoC: Intel: cht_bsw_max98090: add gpio-based jack detection Pierre-Louis Bossart
2017-09-19 13:45 ` Applied "ASoC: Intel: cht_bsw_max98090: add gpio-based jack detection" to the asoc tree Mark Brown
2017-09-18 3:36 ` [PATCH 0/7] BYT/CHT clocks/max98090 updates Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20292830-6f66-a67e-8030-a7eaf808c3fe@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=thierry.escande@collabora.com \
--cc=tiwai@suse.de \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).