From: Alexander Stein <alexanders83@web.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2] ALSA: sound/atmel/ac97c.c: Add device tree support
Date: Fri, 19 Dec 2014 21:51:01 +0100 [thread overview]
Message-ID: <2077365.97bOqiEeM9@kongar> (raw)
In-Reply-To: <20141219204724.GW4885@piout.net>
On Friday 19 December 2014, 21:47:24 wrote Alexandre Belloni:
> On 19/12/2014 at 21:42:54 +0100, Alexandre Belloni wrote :
> > Hi,
> >
> > On 10/12/2014 at 20:59:36 +0100, Alexander Stein wrote :
> > > +#ifdef CONFIG_OF
> > > +static const struct of_device_id atmel_ac97c_dt_ids[] = {
> > > + { .compatible = "atmel,atmel_ac97c", },
> >
> > I would use atmel,at91sam9263-ac97c, we never now, maybe they will have
> > another ac97 IP at some point in time ;)
> >
>
> This applies for the other patches, else I'm fine with the series.
Is this an
> Acked-By Alexandre Belloni <alexandre.belloni@free-electrons.com>
?
> Maybe you could add CONFIG_SND_ATMEL_AC97C=y in at91_dt_defconfig as all
> the other defconfigs have disappeared.
Sure, I'll add both suggestions and respin nother round next week.
Best regards,
Alexander
next prev parent reply other threads:[~2014-12-19 20:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-10 19:59 [PATCH v2] ALSA: sound/atmel/ac97c.c: Add device tree support Alexander Stein
2014-12-10 20:04 ` Lars-Peter Clausen
2014-12-10 20:09 ` Alexander Stein
2014-12-19 20:42 ` Alexandre Belloni
2014-12-19 20:47 ` Alexandre Belloni
2014-12-19 20:51 ` Alexander Stein [this message]
2014-12-19 21:10 ` Alexandre Belloni
2014-12-19 21:05 ` Alexander Stein
2014-12-19 21:12 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2077365.97bOqiEeM9@kongar \
--to=alexanders83@web.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox