From: Florian Fainelli <f.fainelli@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: linux-kernel@vger.kernel.org,
"moderated list:SOUND" <alsa-devel@alsa-project.org>,
arnd@arndb.de, Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH] sound: Add dependency on DMA
Date: Thu, 17 Nov 2016 11:14:52 -0800 [thread overview]
Message-ID: <20c84fff-13d0-e608-1237-6bc567014cc5@gmail.com> (raw)
In-Reply-To: <s5hbmxe9be0.wl-tiwai@suse.de>
On 11/17/2016 11:03 AM, Takashi Iwai wrote:
> On Thu, 17 Nov 2016 19:52:37 +0100,
> Florian Fainelli wrote:
>>
>> Architectures like m32r do not have a proper DMA-API implementation,
>> fixes COMPILE_TEST linking failures for the sounds subsystem.
>
> What error did you get exactly?
> There are already CONFIG_HAS_DMA dependency in a few places, so I
> wonder what's missing.
They looked like these:
sound/built-in.o: In function `snd_pcm_lib_default_mmap':
(.text+0xbb14): undefined reference to `bad_dma_ops'
sound/built-in.o: In function `snd_pcm_lib_default_mmap':
(.text+0xbb1c): undefined reference to `bad_dma_ops'
sound/built-in.o: In function `snd_pcm_lib_default_mmap':
(.text+0xbb34): undefined reference to `dma_common_mmap'
sound/built-in.o: In function `snd_pcm_lib_default_mmap':
(.text+0xbb34): relocation truncated to fit: R_M32R_26_PCREL_RELA
against undefined symbol `dma_common_mmap'
Makefile:961: recipe for target 'vmlinux' failed
I could probably add an ifdef CONFIG_HAS_DMA just surrounding these
snd_pcm_lib if you think this is more appropriate?
--
Florian
next prev parent reply other threads:[~2016-11-17 19:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 18:52 [PATCH] sound: Add dependency on DMA Florian Fainelli
2016-11-17 19:03 ` Takashi Iwai
2016-11-17 19:14 ` Florian Fainelli [this message]
2016-11-17 19:42 ` Florian Fainelli
2016-11-18 8:15 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2016-11-17 18:50 Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20c84fff-13d0-e608-1237-6bc567014cc5@gmail.com \
--to=f.fainelli@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).