From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 820B2CA9EA0 for ; Fri, 25 Oct 2019 14:49:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A44D21929 for ; Fri, 25 Oct 2019 14:49:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="OaCW4Bqw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A44D21929 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 62208180F; Fri, 25 Oct 2019 16:48:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 62208180F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1572014965; bh=09ypQY1uEO+UL427jAUJKic1d1RQIBEK9S7gxe2u3MU=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=OaCW4BqwZlzFIC9rfMOsJzSnYTVsuO64Lp7n2ft3CzaTkqw4qJhV4gfgd+tqoa0G8 L76Znu0tNAtyfNFNyo6cQjTfr43+MdF7gGv2qc5ftoLm9RV4DJdu0DrljeVoOVtkjs 39Cy1Tfsroz1QQp+Lf9iaYdNYf+6jxtMU4/RFVxk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id DBD5CF80112; Fri, 25 Oct 2019 16:48:34 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 8C04EF8036F; Fri, 25 Oct 2019 16:48:33 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 32E97F80112 for ; Fri, 25 Oct 2019 16:48:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 32E97F80112 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 07:48:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,229,1569308400"; d="scan'208";a="223940563" Received: from bnail-mobl.amr.corp.intel.com (HELO [10.252.140.167]) ([10.252.140.167]) by fmsmga004.fm.intel.com with ESMTP; 25 Oct 2019 07:48:25 -0700 To: "Lu, Brent" , "alsa-devel@alsa-project.org" References: <1571994691-20199-1-git-send-email-brent.lu@intel.com> <3ce80285-ddb5-653d-cf60-febc9fd0bdee@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <219281e5-d685-d584-0d22-5dcf3ca2bec2@linux.intel.com> Date: Fri, 25 Oct 2019 09:48:24 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: "Rojewski, Cezary" , Kuninori Morimoto , Tzung-Bi Shih , "linux-kernel@vger.kernel.org" , Jie Yang , Takashi Iwai , Liam Girdwood , Richard Fontana , Mark Brown , "M, Naveen" , Thomas Gleixner , "Subhransu S . Prusty" Subject: Re: [alsa-devel] [PATCH] ASoC: eve: implement set_bias_level function for rt5514 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 10/25/19 9:43 AM, Lu, Brent wrote: >> On 10/25/19 4:11 AM, Brent Lu wrote: >>> The first DMIC capture always fail (zero sequence data from PCM port) >>> after using DSP hotwording function (i.e. Google assistant). >> >> Can you clarify where the DSP hotwording is done? Intel DSP or rt5514? >> >> Turning on the MCLK with the BIAS info might force the Intel DSP to remain >> on, which would impact power consumption if it was supposed to remain off. >> > > Hi Pierre, > > It's done in rt5514's DSP and the interface is SPI instead of I2S for the voice wake > up function. > > There is a driver rt5514-spi.c which provides platform driver and DAI. User space > application first uses the mixer to turn on the voice wake up function: > > amixer -c0 cset name='DSP Voice Wake Up' on > > Then open and read data from the PCM port which goes to the SPI platform and > dai code. Finally it uses same mixer to turn off the function and return to normal > codec mode. The DMIC recording (from I2S) and the voice wake on function should > be mutually exclusive according to the driver design. > > In the codec driver rt5514.c there is a rt5514_set_bias_level function. It's expected to > turn on/off mclk here according to Realtek people's say but our ssp clock requires set > rate function to be called in advance so I implement the code in machine driver. Can you clarify if the rt5514 needs the MCLK while it's doing the hotword detection? My point is really that this patch uses a card-level BIAS indication, and I'd like to make sure this does not interfere with the audio DSP being in D3 state. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel