From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-samsung-soc@vger.kernel.org,
Heiko Stuebner <heiko@sntech.de>,
Sangbeom Kim <sbkim73@samsung.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
Liam Girdwood <lgirdwood@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
Mark Brown <broonie@kernel.org>, Kukjin Kim <kgene@kernel.org>
Subject: Re: [PATCH 3/3] ASoC: samsung: pass filter function as pointer
Date: Tue, 17 Nov 2015 11:25:44 +0100 [thread overview]
Message-ID: <22364793.tICMzOOh4L@wuerfel> (raw)
In-Reply-To: <564A78A6.9010501@samsung.com>
On Tuesday 17 November 2015 09:45:26 Krzysztof Kozlowski wrote:
> On 14.11.2015 02:24, Arnd Bergmann wrote:
> > diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c
> > index 0945b5de39e7..5a4133b6e6a6 100644
> > --- a/sound/soc/samsung/i2s.c
> > +++ b/sound/soc/samsung/i2s.c
> > @@ -1244,7 +1244,8 @@ static int samsung_i2s_probe(struct platform_device *pdev)
> > if (ret != 0)
> > return ret;
> >
> > - return samsung_asoc_dma_platform_register(&pdev->dev);
> > + return samsung_asoc_dma_platform_register(&pdev->dev,
> > + i2s_pdata->dma_filter);
> > }
>
> Here (and maybe in other places?) - NULL pointer exception. The pdata is
> NULL on all newer platforms (e.g. all Exynos).
>
> BTW, later there is even check for NULL pdata which is pointed also by
> Smatch.
Thanks for spotting this! I'll fix it up.
Arnd
next prev parent reply other threads:[~2015-11-17 10:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-13 17:22 [PATCH 1/3] ASoC: samsung: pass DMA channels as pointers Arnd Bergmann
2015-11-13 17:23 ` [PATCH 2/3] ASoC: s3c24xx-i2s: pass DMA channels as platform data Arnd Bergmann
2015-11-17 1:36 ` Krzysztof Kozlowski
2015-11-17 10:19 ` Arnd Bergmann
2015-11-13 17:24 ` [PATCH 3/3] ASoC: samsung: pass filter function as pointer Arnd Bergmann
2015-11-17 0:45 ` Krzysztof Kozlowski
2015-11-17 10:25 ` Arnd Bergmann [this message]
2015-11-17 1:16 ` [PATCH 1/3] ASoC: samsung: pass DMA channels as pointers Krzysztof Kozlowski
2015-11-17 10:24 ` Arnd Bergmann
2015-11-18 1:26 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22364793.tICMzOOh4L@wuerfel \
--to=arnd@arndb.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).