From: "Gorski, Mateusz" <mateusz.gorski@linux.intel.com>
To: alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe
Date: Mon, 27 Apr 2020 13:14:58 +0200 [thread overview]
Message-ID: <237a621b-4326-328f-ed68-05a66cc77cd6@linux.intel.com> (raw)
In-Reply-To: <57f7b40e-a075-ce2f-917b-cf6f2a198f33@linux.intel.com>
>> + list_for_each_entry(ppl, &skl->ppl_list, node) {
>> + if (ppl->pipe->ppl_id == *pipe_id) {
>> + pipe = ppl->pipe;
>> + break;
>> + }
>> + }
>
> is there an alignment issue here or just a diff illusion?
There was, changed in v5.
>
> You also have a number of other alignment/style issues reported by
> checkpatch.pl
>
I have only validated with standard chechpatch.pl settings, scanned with
*--strict *and addressed all warnings in patchset v5.
Thanks,
Mateusz
next prev parent reply other threads:[~2020-04-27 11:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 13:19 [PATCH v4 0/3] Add support for different DMIC configurations Mateusz Gorski
2020-04-24 13:20 ` [PATCH v4 1/3] ASoC: Intel: Skylake: Add alternative topology binary name Mateusz Gorski
2020-04-24 13:20 ` [PATCH v4 2/3] ASoC: Intel: Multiple I/O PCM format support for pipe Mateusz Gorski
2020-04-24 15:26 ` Pierre-Louis Bossart
2020-04-27 11:14 ` Gorski, Mateusz [this message]
2020-04-24 13:20 ` [PATCH v4 3/3] ASoC: Intel: Skylake: Automatic DMIC format configuration according to information from NHLT Mateusz Gorski
2020-04-24 14:52 ` [PATCH v4 0/3] Add support for different DMIC configurations Mark Brown
2020-04-27 11:14 ` Gorski, Mateusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237a621b-4326-328f-ed68-05a66cc77cd6@linux.intel.com \
--to=mateusz.gorski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox