Re: [alsa-devel] [PATCH v2 0/3] Make the audio component binding more generic

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 07/17/2018 04:26 AM, Takashi Iwai wrote:
> Hi,
>
> this is a preliminiary patch set to convert the existing i915 /
> HD-audio component binding to be applicable to other drivers like
> radeon / amdgpu.  This patchset itself doesn't change the
> functionality but only renames and split to a new drm_audio_component
> stuff from i915_audio_component.
>
> The actual usage of the new API will follow once after this one gets
> reviewed / accepted.  The whole patches (including this patchset) are
> found in topic/hda-acomp branch of sound.git tree.
>
> BTW, since the whole stuff is about the audio binding, I suppose these
> will go through sound git tree.  Let me know if anyone has concerns.
No objections but a slight concern that this will conflict with the 
HDAudio+DSP patches that I was about to resubmit on top of your 
topic/hda-core-intel branch. the two series touch the same files so it'd 
be a miracle if there is no issue.
How do you want to deal with this?
>
>
> Thanks!
>
> Takashi
>
> ===
>
> v1->v2:
> * Change to SPDX for the new drm_audio_component.h
> * Fix remaining i915 word in drm_audio_component.h comments
> * Fix NULL dereference in master_bind / _unbind ops
>
> ===
>
> Takashi Iwai (3):
>    drm/i915: Split audio component to a generic type
>    ALSA: hda/i915: Associate audio component with devres
>    ALSA: hda: Make audio component support more generic
>
>   drivers/gpu/drm/i915/Kconfig       |   1 +
>   drivers/gpu/drm/i915/intel_audio.c |  22 +-
>   include/drm/drm_audio_component.h  | 118 ++++++++++
>   include/drm/i915_component.h       |  85 +-------
>   include/sound/hda_component.h      |  61 ++++++
>   include/sound/hda_i915.h           |  37 +---
>   include/sound/hdaudio.h            |   6 +-
>   sound/hda/Kconfig                  |   7 +-
>   sound/hda/Makefile                 |   1 +
>   sound/hda/hdac_component.c         | 335 +++++++++++++++++++++++++++++
>   sound/hda/hdac_i915.c              | 335 ++---------------------------
>   sound/pci/hda/patch_hdmi.c         |  57 +++--
>   sound/soc/codecs/hdac_hdmi.c       |  10 +-
>   13 files changed, 607 insertions(+), 468 deletions(-)
>   create mode 100644 include/drm/drm_audio_component.h
>   create mode 100644 include/sound/hda_component.h
>   create mode 100644 sound/hda/hdac_component.c
>

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx