From: Jyri Sarha <oku@iki.fi>
To: Mark Brown <broonie@kernel.org>
Cc: Darren Etheridge <detheridge@ti.com>,
alsa-devel@alsa-project.org, devicetree-discuss@lists.ozlabs.org,
Jyri Sarha <jsarha@ti.com>,
"Hebbar, Gururaja" <gururaja.hebbar@ti.com>,
liam.r.girdwood@linux.intel.com
Subject: Re: [PATCH RFC 2/8] ASoC: davinci-evm: Add device tree binding
Date: Wed, 11 Sep 2013 21:02:06 +0300 [thread overview]
Message-ID: <26fb2b5213b7ea9c8bd9e2ef023614a3@kapsi.fi> (raw)
In-Reply-To: <20130911113533.GQ29403@sirena.org.uk>
On 2013-09-11 14:35, Mark Brown wrote:
> On Wed, Sep 11, 2013 at 01:38:47PM +0300, Jyri Sarha wrote:
>
> After checking the code, are you sure about this? Non of the other
> codecs have pins in their devicetree binding document?
>
> Yes, I am sure and yes there are other CODECs with pins listed, check
> again.
I wonder if I somehow misunderstood your first comment. I just
noticed that davinci-evm-audio.txt is missing all the output pins and
some connectors that are found in the code and also in the example
node. I will add those.
I can of course also add the list of pins to Documentation/devicetree/
bindings/sound/tlv320aic3x.txt, if that was what you meant. It would
make sense to have the pins there. However, I really can not find the
list of pins from any of the Wolfson codec binding documents
(Documentation/devicetree/bindings/sound/wm*.txt) for exmaple. Are you
perhaps refering to some other document or is the convention changing
for v3.12?
When comparing the codec bindings I found that the regulators are
missing from tlv320aic3x.txt. I'll add those too.
Best regards,
Jyri
next prev parent reply other threads:[~2013-09-11 18:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-09 15:12 [PATCH RFC 0/8] Fix AM335x-evm analog audio support oku
2013-09-09 15:12 ` [PATCH RFC 1/8] ASoC: davinci-mcasp: Add pinctrl support oku
2013-09-09 15:19 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 2/8] ASoC: davinci-evm: Add device tree binding oku
2013-09-09 15:21 ` Mark Brown
2013-09-11 10:38 ` Jyri Sarha
2013-09-11 11:35 ` Mark Brown
2013-09-11 18:02 ` Jyri Sarha [this message]
2013-09-12 11:47 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 3/8] ASoC: davinci-mcasp: Get DMA related properties from DT oku
2013-09-09 15:25 ` Mark Brown
2013-09-11 11:48 ` Jyri Sarha
2013-09-12 11:08 ` Mark Brown
2013-09-12 11:34 ` Jyri Sarha
2013-09-12 11:56 ` Mark Brown
2013-09-12 12:10 ` Jyri Sarha
2013-09-13 10:34 ` Mark Brown
2013-09-13 10:50 ` Jyri Sarha
2013-09-13 17:53 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 4/8] ASoC: davinci-mcasp: Extract DMA channels directly " oku
2013-09-09 15:12 ` [PATCH RFC 5/8] ASoC: davinci: Add support for AM33xx SoC Audio oku
2013-09-09 15:24 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 6/8] ARM/dts: am33xx: Add mcasp0 and mcasp1 device tree entries oku
2013-09-09 15:27 ` Mark Brown
2013-09-09 15:12 ` [PATCH RFC 7/8] ARM/dts: am33xx: mcasp: Add new dma related properties oku
2013-09-09 15:12 ` [PATCH RFC 8/8] ARM/dts: am335x-evm: Add audio support for am335x-evm.dts oku
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26fb2b5213b7ea9c8bd9e2ef023614a3@kapsi.fi \
--to=oku@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=detheridge@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=gururaja.hebbar@ti.com \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).