From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF35EC433EF for ; Fri, 3 Dec 2021 22:59:54 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 09D2221C5; Fri, 3 Dec 2021 23:59:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 09D2221C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1638572392; bh=28SC4E/VIjLWgyBHitNAIzN+kGECqyK+JI792awt9MY=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=BF1ECVZAK0btTvO81GzI3E9AZge20kbiXI35RXCwcRs9Y0u2PwnVbCn3h04xalQta 2nF1XV0rH1D+t3lzRha7SDUmtpjAv2rJ17JTnlrhAjQkp5W3oK77ku5r2ku47Pk1vk 886uV42r0QYOrYK6VJS0c/GgGSRn2sN0qNqXGdP4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 78098F8015B; Fri, 3 Dec 2021 23:59:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 55B0FF80246; Fri, 3 Dec 2021 23:58:59 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F1FC5F80085 for ; Fri, 3 Dec 2021 23:58:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F1FC5F80085 X-IronPort-AV: E=McAfee;i="6200,9189,10187"; a="236884454" X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="236884454" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 14:58:46 -0800 X-IronPort-AV: E=Sophos;i="5.87,284,1631602800"; d="scan'208";a="461064086" Received: from hkagda-mobl2.amr.corp.intel.com (HELO [10.212.71.79]) ([10.212.71.79]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Dec 2021 14:58:45 -0800 Subject: Re: [bug report] ASoC: Intel: mrfld - create separate module for pci part To: Andy Shevchenko , fntoth@gmail.com References: <20211202151322.GA21325@kili> <19647b98-83fd-b493-0fed-3c4e43cbeba8@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <27281df2-5429-c9b0-8264-b030faa6a539@linux.intel.com> Date: Fri, 3 Dec 2021 16:58:41 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, Takashi Iwai , Hans de Goede , vkoul@kernel.org, Mark Brown , Dan Carpenter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> I would guess that indeed a return 0; is missing, but maybe it's time to >>> remove this PCI code completely. I can't think of any user of the PCI >>> parts of this driver. >>> >>> Andy, Hans, Mark, Takashi, what do you think? >> >> The Edison platform and actually some more based on Intel Merrifield are still >> alive and on the (second hand) market. But yes, I would rather focus on making >> SOF working there, but via PCI bus (or with ACPI, ASL code for which one should >> actually write down, currently it's a device with PCI interface only). > > That said, Pierre, have you been able to setup your Edison to see anything on > I2S with SOF? No, I haven't touched my Edison boards since the initial integration with you and Ferry in 2020. I see that the firmware was updated to 1.8 and the kernel is 5.10+ now, so that should be easier than last time. We don't really need any change for the driver probe, PCI is just fine, what's missing is an ACPI recipe to enable audio functionality over the SSP pins.