Re: [PATCH] ASoC: rt1320-sdw: kcontrol for brown-out feature switch

Mark Brown
2026-04-02T11:15:12Z

[-- Attachment #1: Type: text/plain, Size: 546 bytes --]

On Thu, Apr 02, 2026 at 04:37:53AM +0000, Jack Yu wrote:

> > > +static const char * const rt1320_brown_out_mode[] = {
> > > + "On",
> > > + "Off",
> > > +};

> > > +static SOC_ENUM_SINGLE_DECL(rt1320_brown_out_enum, 0, 0,
> > > + rt1320_brown_out_mode);

> > On/off switches should be a Switch control, not an enum.

> Maybe the name of kcontrol leads to misunderstand, it's just an effect setting for amplifier.
> I'll update this and use another control type but not enum.

Turning effects on and off are still things being turned on and off.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]