From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F0CDC54FCB for ; Fri, 24 Apr 2020 15:45:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 13F2820767 for ; Fri, 24 Apr 2020 15:45:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="lrIt85gN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 13F2820767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6F5F316A8; Fri, 24 Apr 2020 17:44:37 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6F5F316A8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1587743127; bh=BQz0K2EclqNduXJhyE7B1dsT4ToT9UJL+qx5eOgPrKc=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=lrIt85gNYJdWzFkNlfvEx8KA5A9h3gDHLgnqYqKDUS0EPHO/H9OD0CsONxBy1390F tLvM6N2aZ5bfc8o6LXutNO/AfXSlZzLSPxzHGGPePL2+9QYpk7M3F0BcTmhlQaZMP3 Olnn2hltNIXez+nAA9Z6jTaQnr/nU448HP+oX8oY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EA4AEF80116; Fri, 24 Apr 2020 17:44:36 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 15111F80142; Fri, 24 Apr 2020 17:44:35 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 6584FF80116 for ; Fri, 24 Apr 2020 17:44:30 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 6584FF80116 IronPort-SDR: m1RjBTi3KnPP19ozkOTn1rMSS9ncNrqZr45j1vWCK6YsrCBKp8c3XqpfuzLdCCPdUYrSlGunQS u+H0X/e8/sJQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 08:44:28 -0700 IronPort-SDR: ycRuODqh4DGXjF1+X4wSFFhGFp8Hg8fD3pO8NSzlQaoiT1TRk2VtL69UKbfrx4UiaScbbLncQH LwhAxku5pf2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,311,1583222400"; d="scan'208";a="274628742" Received: from jinglu1-mobl1.amr.corp.intel.com (HELO [10.254.176.234]) ([10.254.176.234]) by orsmga002.jf.intel.com with ESMTP; 24 Apr 2020 08:44:27 -0700 Subject: Re: [PATCH] ASoC: snd-sof-intel-hda-common - add hda_model parameter and pass it to HDA codec driver To: Takashi Iwai , Kai Vehmanen References: <20200424092520.23989-1-perex@perex.cz> From: Pierre-Louis Bossart Message-ID: <28900433-f2a7-bf4e-7861-5522f0aedee1@linux.intel.com> Date: Fri, 24 Apr 2020 10:44:27 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: ALSA development , Mark Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> Hmm, I wonder is this now doing more harm than good. Based on browsing >> through the related code in hda-codec.c and friends, it would seem >> "sofbus" as the default is mostly harmless, but I could have missed >> something. > > That's currently harmless since no codec driver defines "sofbus" > model, hence the HDA parser continues to match with the default > quirks. OTOH, the fixed "sofbus" model is fairly useless. So, feel > free to take my ack, too: For my education, are you saying that the default should be that the modelname is NULL, and the hda auto parser will use known quirks based on PCI/SSID information, and when the user sets the model name to a non-NULL string it will force a specific quirk to be used? Thanks!