From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org,
"Gustavo A. R. Silva" <garsilva@embeddedor.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 5/7] ASoC: wm8753: mark expected switch fall-throughs
Date: Wed, 8 Nov 2017 14:04:31 -0600 [thread overview]
Message-ID: <2a3113ceca1b3f70258486038ed93cfbed70741c.1510170034.git.garsilva@embeddedor.com> (raw)
In-Reply-To: <cover.1510170034.git.garsilva@embeddedor.com>
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 146568
Addresses-Coverity-ID: 146569
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
sound/soc/codecs/wm8753.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/wm8753.c b/sound/soc/codecs/wm8753.c
index d05d76e..0271a52 100644
--- a/sound/soc/codecs/wm8753.c
+++ b/sound/soc/codecs/wm8753.c
@@ -971,7 +971,7 @@ static int wm8753_pcm_set_dai_fmt(struct snd_soc_codec *codec,
case SND_SOC_DAIFMT_CBS_CFS:
break;
case SND_SOC_DAIFMT_CBM_CFM:
- ioctl |= 0x2;
+ ioctl |= 0x2; /* fall through */
case SND_SOC_DAIFMT_CBM_CFS:
voice |= 0x0040;
break;
@@ -1096,7 +1096,7 @@ static int wm8753_i2s_set_dai_fmt(struct snd_soc_codec *codec,
case SND_SOC_DAIFMT_CBS_CFS:
break;
case SND_SOC_DAIFMT_CBM_CFM:
- ioctl |= 0x1;
+ ioctl |= 0x1; /* fall through */
case SND_SOC_DAIFMT_CBM_CFS:
hifi |= 0x0040;
break;
--
2.7.4
next prev parent reply other threads:[~2017-11-08 20:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-08 20:03 [PATCH 0/7] mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-08 20:04 ` [PATCH 1/7] ASoC: msm8916-wcd-analog: mark expected switch fall-through Gustavo A. R. Silva
2017-11-08 21:31 ` Applied "ASoC: msm8916-wcd-analog: mark expected switch fall-through" to the asoc tree Mark Brown
2017-11-08 20:04 ` [PATCH 2/7] ASoC: tlv320aic23: mark expected switch fall-through Gustavo A. R. Silva
2017-11-08 21:31 ` Applied "ASoC: tlv320aic23: mark expected switch fall-through" to the asoc tree Mark Brown
2017-11-08 20:04 ` [PATCH 3/7] ASoC: tlv320dac31xx: mark expected switch fall-through Gustavo A. R. Silva
2017-11-08 21:31 ` Applied "ASoC: tlv320dac31xx: mark expected switch fall-through" to the asoc tree Mark Brown
2017-11-08 20:04 ` [PATCH 4/7] ASoC: tpa6130a2: mark expected switch fall-through Gustavo A. R. Silva
2017-11-08 21:31 ` Applied "ASoC: tpa6130a2: mark expected switch fall-through" to the asoc tree Mark Brown
2017-11-08 20:04 ` Gustavo A. R. Silva [this message]
2017-11-08 21:31 ` Applied "ASoC: wm8753: mark expected switch fall-throughs" " Mark Brown
2017-11-08 20:04 ` [PATCH 6/7] ASoC: wm8993: mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-08 21:31 ` Applied "ASoC: wm8993: mark expected switch fall-throughs" to the asoc tree Mark Brown
2017-11-08 20:04 ` [PATCH 7/7] ASoC: wm8994: mark expected switch fall-throughs Gustavo A. R. Silva
2017-11-08 21:31 ` Applied "ASoC: wm8994: mark expected switch fall-throughs" to the asoc tree Mark Brown
2017-11-23 6:41 ` [PATCH 7/7] ASoC: wm8994: mark expected switch fall-throughs Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3113ceca1b3f70258486038ed93cfbed70741c.1510170034.git.garsilva@embeddedor.com \
--to=garsilva@embeddedor.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).