Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: broonie@kernel.org, tiwai@suse.com, linux@dominikbrodowski.net
Subject: Re: [PATCH 0/3] ASoC: Intel: boards: Revert SSP0 links to use dummy
Date: Wed, 25 Mar 2020 09:37:03 -0500	[thread overview]
Message-ID: <2c22bea1-3139-260d-153d-04e9d212e3be@linux.intel.com> (raw)
In-Reply-To: <20200325131611.545-1-cezary.rojewski@intel.com>



On 3/25/20 8:16 AM, Cezary Rojewski wrote:
> Recent series of patches targeting broadwell boards, while enabling
> SOF, changed behavior for non-SOF solutions. In essence replacing
> platform 'dummy' with actual 'platform' causes redundant stream
> initialization to occur during audio start. hw_params for haswell-pcm
> destroys initial stream right after its creation - only to recreate it
> again from proceed from there.
> 
> While harmless so far, this flow isn't right and should be corrected.
> The actual need for dummy components for SSP0 link is questionable but
> that issue is subject for another series.
> 
> Link to first message in conversation:
> https://lkml.org/lkml/2020/3/18/54
> 
> Cezary Rojewski (3):
>    ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components
>    ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components
>    ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components

Thanks Cezary, for the series

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> 
>   sound/soc/intel/boards/bdw-rt5650.c | 7 ++++---
>   sound/soc/intel/boards/bdw-rt5677.c | 7 ++++---
>   sound/soc/intel/boards/broadwell.c  | 7 ++++---
>   3 files changed, 12 insertions(+), 9 deletions(-)
> 

      parent reply	other threads:[~2020-03-25 15:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-25 13:16 [PATCH 0/3] ASoC: Intel: boards: Revert SSP0 links to use dummy Cezary Rojewski
2020-03-25 13:16 ` [PATCH 1/3] ASoC: Intel: broadwell: Revert back SSP0 link to use dummy components Cezary Rojewski
2020-03-25 13:16 ` [PATCH 2/3] ASoC: Intel: bdw-rt5677: Revert " Cezary Rojewski
2020-03-25 21:33   ` Applied "ASoC: Intel: bdw-rt5677: Revert SSP0 link to use dummy components" to the asoc tree Mark Brown
2020-03-25 13:16 ` [PATCH 3/3] ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components Cezary Rojewski
2020-03-25 21:33   ` Applied "ASoC: Intel: bdw-rt5650: Revert SSP0 link to use dummy components" to the asoc tree Mark Brown
2020-03-25 14:37 ` Pierre-Louis Bossart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c22bea1-3139-260d-153d-04e9d212e3be@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=linux@dominikbrodowski.net \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox