Re: [PATCH] ASoC: Intel: boards: Add Cometlake machine driver support

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

>> diff --git a/sound/soc/intel/common/soc-intel-quirks.h 
>> b/sound/soc/intel/common/soc-intel-quirks.h
>> index 4718fd3..e6357d3 100644
>> --- a/sound/soc/intel/common/soc-intel-quirks.h
>> +++ b/sound/soc/intel/common/soc-intel-quirks.h
>> @@ -36,6 +36,7 @@ SOC_INTEL_IS_CPU(byt, INTEL_FAM6_ATOM_SILVERMONT);
>>   SOC_INTEL_IS_CPU(cht, INTEL_FAM6_ATOM_AIRMONT);
>>   SOC_INTEL_IS_CPU(apl, INTEL_FAM6_ATOM_GOLDMONT);
>>   SOC_INTEL_IS_CPU(glk, INTEL_FAM6_ATOM_GOLDMONT_PLUS);
>> +SOC_INTEL_IS_CPU(cml, INTEL_FAM6_KABYLAKE_MOBILE);
>>   static inline bool soc_intel_is_byt_cr(struct platform_device *pdev)
>>   {
>> @@ -110,6 +111,10 @@ static inline bool soc_intel_is_glk(void)
>>       return false;
>>   }
>> +static inline bool soc_intel_is_cml(void)
>> +{
>> +    return false;
>> +}
>>   #endif
>>    #endif /* _SND_SOC_INTEL_QUIRKS_H */
> 
> Humm, which branch does this apply against? It's not in Mark's tree nor 
> in the SOF tree, so how did you test this?
> 
> I remember submitting this quirk suggestion but it was not approved 
> upstream, or needed more work (this was before I dropped everything to 
> work on SoundWire). You may have to do this manually for now with the 
> cpu_id method, and we'll replace it later with a better solution.

Please ignore this last comment, I need more coffee before reviewing. 
The code was indeed merged...
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel