Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Cc: Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [RFC] dpcm_fe_dai_do_trigger: implicit removal of _DRAIN cmd since v5.4
Date: Thu, 3 Sep 2020 11:01:41 +0200	[thread overview]
Message-ID: <2eea3479-1efb-ec82-32f2-e89614998aaa@intel.com> (raw)

Hello,

Till v5.4 dpcm_fe_dai_do_trigger was supporting all pcm cmds as each 
case: SND_SOC_DPCM_TRIGGER_PRE/ _POST/ _BESPOKE was simply passing cmd's 
value to appropriate variant of _trigger().

Since the addition of:
	acbf27746ecfa96b290b54cc7f05273482ea128a
	ASoC: pcm: update FE/BE trigger order based on the command

additional filters have been introduced for _PRE and _POST cases:

	switch (cmd) {
	case SNDRV_PCM_TRIGGER_START:
	case SNDRV_PCM_TRIGGER_RESUME:
	case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
		ret = dpcm_dai_trigger_fe_be(substream, cmd, true);
		break;
	case SNDRV_PCM_TRIGGER_STOP:
	case SNDRV_PCM_TRIGGER_SUSPEND:
	case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
		ret = dpcm_dai_trigger_fe_be(substream, cmd, false);
		break;
	default:
		ret = -EINVAL;
		break;
	}

effectively removing support for _DRAIN command - all requests will 
yield -EINVAL. _BESPOKE was left alone so support remained there.

Now, is DPCM no longer supporting _DRAIN and that's how things should be 
-or- DPCM still intends to support _DRAIN and mentioned change is 
unintended regression?

Czarek

             reply	other threads:[~2020-09-03  9:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03  9:01 Cezary Rojewski [this message]
2020-09-15 16:58 ` [RFC] dpcm_fe_dai_do_trigger: implicit removal of _DRAIN cmd since v5.4 Sridharan, Ranjani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2eea3479-1efb-ec82-32f2-e89614998aaa@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox