Re: [PATCH v2] ASoC: Intel: add sof-nau8825 machine driver

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 11/1/21 6:00 AM, Mac Chiang wrote:
> From: David Lin <CTLIN0@nuvoton.com>
> 
> The machine driver is a generic machine driver for SOF with nau8825
> codec w or w/o speaker additionally. Depending on the SOC
> HDMI, DMIC, Bluetooth offload support are added dynamically.
> 
> Only add information related to SOF since the machine driver was
> only tested with SOF.
> 
> There are currently 4 i2s machine variants of ADL.
> This supports the headphone NUA8825(SSP0) alone or with smart or dumb
> speakers.
> Board 2,3,4 use SSP2 for Bluetooth offload support except board 1.
> 
> Board 1 : NAU8825 + RT1019P(SSP2)
> Board 2 : NAU8825 + MAX98373(SSP1)
> Board 3 : NAU8825 + MAX98360A(SSP1)
> Board 4 : NAU8825
> 
> Signed-off-by: David Lin <CTLIN0@nuvoton.com>
> Co-developed-by: Mac Chiang <mac.chiang@intel.com>
> Signed-off-by: Mac Chiang <mac.chiang@intel.com>
> ---
>   1. remove hdac_hdmi relevant codes support
>   2. remove duplicated max_98360a_dai_link calls. Instead of checking no_amp condition
>   3. alter module license name to "GPL"
>   4. due to rt1019 non-i2c mode, so change to SND_SOC_RT1015P in KConfig
> ---

Looks good to me, thanks.

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>