From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Chuhong Yuan <hslester96@gmail.com>
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: sof-rt5682: add a check for devm_clk_get
Date: Thu, 17 Oct 2019 08:16:22 -0500 [thread overview]
Message-ID: <31fb322b-c0c2-b783-47bc-52be842f8661@linux.intel.com> (raw)
In-Reply-To: <20191017025044.31474-1-hslester96@gmail.com>
On 10/16/19 9:50 PM, Chuhong Yuan wrote:
> sof_audio_probe misses a check for devm_clk_get and may cause problems.
> Add a check for it to fix the bug.
Indeed this is a miss, we have this test in all machine drivers except
this one. Thanks for the patch!
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> sound/soc/intel/boards/sof_rt5682.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/sound/soc/intel/boards/sof_rt5682.c b/sound/soc/intel/boards/sof_rt5682.c
> index a437567b8cee..6d15c7ff66bf 100644
> --- a/sound/soc/intel/boards/sof_rt5682.c
> +++ b/sound/soc/intel/boards/sof_rt5682.c
> @@ -576,6 +576,15 @@ static int sof_audio_probe(struct platform_device *pdev)
> /* need to get main clock from pmc */
> if (sof_rt5682_quirk & SOF_RT5682_MCLK_BYTCHT_EN) {
> ctx->mclk = devm_clk_get(&pdev->dev, "pmc_plt_clk_3");
> + if (IS_ERR(ctx->mclk)) {
> + ret = PTR_ERR(ctx->mclk);
> +
> + dev_err(&pdev->dev,
> + "Failed to get MCLK from pmc_plt_clk_3: %d\n",
> + ret);
> + return ret;
> + }
> +
> ret = clk_prepare_enable(ctx->mclk);
> if (ret < 0) {
> dev_err(&pdev->dev,
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-17 14:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 2:50 [alsa-devel] [PATCH] ASoC: Intel: sof-rt5682: add a check for devm_clk_get Chuhong Yuan
2019-10-17 13:16 ` Pierre-Louis Bossart [this message]
2019-10-18 18:07 ` [alsa-devel] Applied "ASoC: Intel: sof-rt5682: add a check for devm_clk_get" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31fb322b-c0c2-b783-47bc-52be842f8661@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hslester96@gmail.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox