From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC20EC4CEC9 for ; Wed, 18 Sep 2019 10:16:50 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 76CAA218AF for ; Wed, 18 Sep 2019 10:16:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="eYrgvJ38" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 76CAA218AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=codethink.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 964E21673; Wed, 18 Sep 2019 12:15:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 964E21673 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1568801808; bh=Yg8zyD+v3yrCJYCsAoVvxsoeaiEP6wbGkhFlc81khTg=; h=Date:From:To:In-Reply-To:References:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=eYrgvJ38WqzP5r+SiXqRR8xjvPcTfASzp9+KnR9IjME3WsJR92w5PPF9RbZnTNBzo kWV815LngJ5UeqqGfSO2YPzIUO8iturcvangrK0iZozexrv3lfVBcp84APzkmqlKDP yom+TCelBE/D6ELLAI0FHK+s99BaVCuCWWIOQemc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 129D3F804FF; Wed, 18 Sep 2019 12:15:58 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AC461F80527; Wed, 18 Sep 2019 12:15:55 +0200 (CEST) Received: from imap1.codethink.co.uk (imap1.codethink.co.uk [176.9.8.82]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 54F7FF80146 for ; Wed, 18 Sep 2019 12:15:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 54F7FF80146 Received: from [78.40.148.177] (helo=localhost) by imap1.codethink.co.uk with esmtpsa (Exim 4.84_2 #1 (Debian)) id 1iAX02-00063i-Ag; Wed, 18 Sep 2019 11:15:50 +0100 MIME-Version: 1.0 Date: Wed, 18 Sep 2019 11:15:49 +0100 From: Ben Dooks To: Jon Hunter In-Reply-To: <854421d9-8c5b-0960-1864-0cf8f1018696@nvidia.com> References: <20190917181233.534-1-ben.dooks@codethink.co.uk> <20190917181233.534-6-ben.dooks@codethink.co.uk> <854421d9-8c5b-0960-1864-0cf8f1018696@nvidia.com> Message-ID: <3438cecb8ed89a96cfb30127dbd5e770@codethink.co.uk> X-Sender: ben.dooks@codethink.co.uk User-Agent: Roundcube Webmail/1.3.10 Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org, Liam Girdwood , Takashi Iwai , Mark Brown , Thierry Reding , linux-tegra@vger.kernel.org, linux-tegra-owner@vger.kernel.org Subject: Re: [alsa-devel] [PATCH 5/8] ASoC: tegra: set edge mode for TDM correctly X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2019-09-18 10:02, Jon Hunter wrote: > On 18/09/2019 09:54, Jon Hunter wrote: >> >> On 17/09/2019 19:12, Ben Dooks wrote: >>> In TDM, use the negative edge to drive data and the positive edge to >>> sample >>> data. >>> >>> Signed-off-by: Ben Dooks >>> --- >>> sound/soc/tegra/tegra30_i2s.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/sound/soc/tegra/tegra30_i2s.c >>> b/sound/soc/tegra/tegra30_i2s.c >>> index 4222839b63bd..d75ce12fe177 100644 >>> --- a/sound/soc/tegra/tegra30_i2s.c >>> +++ b/sound/soc/tegra/tegra30_i2s.c >>> @@ -117,6 +117,8 @@ static int tegra30_i2s_set_fmt(struct snd_soc_dai >>> *dai, >>> } >>> >>> pm_runtime_get_sync(dai->dev); >>> + regmap_update_bits(i2s->regmap, TEGRA30_I2S_CH_CTRL_EGDE_CTRL_MASK, >>> + i2s->is_tdm ? TEGRA30_I2S_CH_CTRL_EGDE_CTRL_NEG_EDGE : 0); >>> regmap_update_bits(i2s->regmap, TEGRA30_I2S_CTRL, mask, val); >>> pm_runtime_put(dai->dev); >> >> I would rather set this in the case statement above where the format >> is >> parsed and again drop this 'is_tdm' variable. > > Actually, this should be implemented as shown in the following ... > > https://nv-tegra.nvidia.com/gitweb/?p=linux-nvidia.git;a=blob;f=sound/soc/tegra-alt/tegra210_i2s_alt.c;h=ee482f27ed2e4710e5e7446918887f8f8ef31285;hb=a960d522a5486aee27605f890034869c4f49d94a#l362 > > Jon Ok, will look at that. Note, nv-tegra.nvidia.com seems to have a security problem . _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel