From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76880C48BDF for ; Tue, 15 Jun 2021 16:01:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6172161490 for ; Tue, 15 Jun 2021 16:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6172161490 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9D850169D; Tue, 15 Jun 2021 18:00:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9D850169D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1623772879; bh=y3LdWgYrhG0RCCsbHUtzZIkdvtA6lC/jkbvfWaPhT3g=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JyoRRngyTZgzH6EmaGBx24Ks3sjM1lPqSnoyUBK72zvquHl2gl/JHjvIUZTzdEV6S V1od3888VX4ZwH+kj+rgyIhjzX3WzMKtNBgp/vylb2sPIT2pMZygoKXXpokHmQrhu7 GyiTDcsQEu99ahuMn+Ag+JRbBihmTCLnxBKNPSZs= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 2773BF8016C; Tue, 15 Jun 2021 18:00:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 971C4F80113; Tue, 15 Jun 2021 18:00:27 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 62C89F80113 for ; Tue, 15 Jun 2021 18:00:18 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 62C89F80113 IronPort-SDR: aUZk6ExugD1rpWh0/dWpOlhFchnl77eRicCJh+BupwxqSonYP3NTzo4u9C5Tv9uOmi6C0NqMbX 0uuI7PUH8bTw== X-IronPort-AV: E=McAfee;i="6200,9189,10016"; a="269868541" X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="269868541" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2021 09:00:14 -0700 IronPort-SDR: VuzC0kwC5Gd7fL4dcEBxLlwVKjbOSfVaWfYUJJcNryXABhVaEK7CES8NVtdky/X2ZqPP4QFqfA bw9EeubIQywg== X-IronPort-AV: E=Sophos;i="5.83,275,1616482800"; d="scan'208";a="487823401" Received: from bgeagarc-mobl1.amr.corp.intel.com (HELO [10.209.128.67]) ([10.209.128.67]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2021 09:00:11 -0700 Subject: Re: [PATCH] ASoC: max98357a: set channels_max to 4 To: Cheng-yi Chiang , Tzung-Bi Shih References: <20210526154704.114957-1-judyhsiao@chromium.org> From: Pierre-Louis Bossart Message-ID: <3501e398-dfba-43b1-4638-325a158e860d@linux.intel.com> Date: Tue, 15 Jun 2021 11:00:10 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Taniya Das , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , ALSA development , Banajit Goswami , Stephan Gerhold , Liam Girdwood , linux-arm-msm , Patrick Lai , Takashi Iwai , Tzung-Bi Shih , Stephen Boyd , Rob Herring , Andy Gross , Rohit kumar , Mark Brown , Douglas Anderson , Dylan Reid , Bjorn Andersson , Judy Hsiao , "moderated list:ARM/Mediatek SoC support" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 6/15/21 10:47 AM, Cheng-yi Chiang wrote: > Hi Tzung-Bi, > > On a platform, the four max98357a amps will be controlled by only one > codec device, as GPIO for SD_MODE is shared by all amps and is the > only thing to be controlled. > In this sense, I think we can treat max98357a DAI as if it supports > four channels. > I understand that this solution is not scalable, because one can > control as many amps as they want. > Theoretically, the number of supported channels by this codec device > is unlimited. > I found that rt1015.c has similar usage. > Do you have a better suggestion to support this kind of use case ? > Thanks! please don't top-post... I don't think it's correct to declare 4-channel support at the individual codec DAI level when in practice each device will be provided with a TDM mask that selects two slots. This is confusing device capabilities and TDM link configuration. > On Tue, Jun 1, 2021 at 2:20 PM Tzung-Bi Shih wrote: >> >> On Wed, May 26, 2021 at 11:47 PM Judy Hsiao wrote: >>> Sets channels_max to 4 to support QUAD channel. >> >> Could you point out probably the up-to-date MAX98357A datasheet for >> 4-channel support? >> >> On a related note, from the public datasheet I could find[1], "Table >> 5" only shows 2 channel's configuration. >> >> [1]: https://pdf1.alldatasheet.com/datasheet-pdf/view/623796/MAXIM/MAX98357A.html