From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, Vinod <vkoul@kernel.org>
Cc: tiwai@suse.de, liam.r.girdwood@linux.intel.com,
alsa-devel@alsa-project.org,
Rakesh Ughreja <rakesh.a.ughreja@intel.com>
Subject: Re: [PATCH v4 7/8] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers
Date: Thu, 26 Jul 2018 10:36:08 -0500 [thread overview]
Message-ID: <358b0fb8-7346-066d-62e9-fd210e80b2b3@linux.intel.com> (raw)
In-Reply-To: <20180726145812.GG2414@sirena.org.uk>
On 07/26/2018 09:58 AM, Mark Brown wrote:
> On Wed, Jul 25, 2018 at 09:59:14PM +0530, Vinod wrote:
>> On 25-07-18, 09:27, Pierre-Louis Bossart wrote:
>>>>> +/* SPDX-License-Identifier: GPL-2.0 */
>>>>> +/*
>>>>> + * Copyright(c) 2015-17 Intel Corporation.
>>>>> + */
>>>> same patch different style ;/
>>> ok. Checkpatch reports different things for SPDX but I'll align on the C++
>>> version.
>> Yeah we still have bunch of versions floating out. Only consensus seems
>> to be for SPDX line in C99 style. So pick one you like and be consistent
>> with it.
> Headers are a C comment as they might be included by non-C stuff.
Ah, makes sense. if that's alright I'll use the following style then.
.h files
/* SPDX-License-Identifier: GPL-2.0 */
/*
* Copyright(c) 2015-17 Intel Corporation.
*/
.c files
// SPDX-License-Identifier: GPL-2.0
/*
* Copyright(c) 2015-17 Intel Corporation.
*/
next prev parent reply other threads:[~2018-07-26 15:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 0:50 [PATCH v4 0/8] Enable HDA Codec support on Intel Platforms Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 1/8] ASoC: Intel: Skylake: fix widget handling Pierre-Louis Bossart
2018-07-25 10:59 ` Vinod
2018-07-25 14:04 ` Pierre-Louis Bossart
2018-07-25 16:11 ` Vinod
2018-07-25 16:39 ` Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 2/8] ASoC: Intel: common: add table for HDA-based platforms Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 3/8] ASoC: Intel: Boards: Machine driver for SKL+ w/ HDAudio codecs Pierre-Louis Bossart
2018-07-25 11:11 ` Vinod
2018-07-25 14:10 ` Pierre-Louis Bossart
2018-07-25 16:22 ` Vinod
2018-07-25 16:45 ` Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 4/8] ASoC: Intel: Skylake: use HDAudio if ACPI enumeration fails Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 5/8] ASoC: Intel: Skylake: add HDA BE DAIs Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 6/8] ASoC: Intel: Skylake: use hda_bus instead of hdac_bus Pierre-Louis Bossart
2018-07-25 0:50 ` [PATCH v4 7/8] ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers Pierre-Louis Bossart
2018-07-25 11:47 ` Vinod
2018-07-25 14:27 ` Pierre-Louis Bossart
2018-07-25 16:29 ` Vinod
2018-07-26 14:58 ` Mark Brown
2018-07-26 15:36 ` Pierre-Louis Bossart [this message]
2018-07-26 16:31 ` Mark Brown
2018-07-25 0:50 ` [PATCH v4 8/8] ASoC: Intel: Skylake: add option to control HDAudio + DSP usage Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=358b0fb8-7346-066d-62e9-fd210e80b2b3@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=rakesh.a.ughreja@intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox