From: Andrew Paprocki <andrew@ishiboo.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de
Subject: [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec
Date: Fri, 14 Dec 2007 12:48:00 -0400 [thread overview]
Message-ID: <3681a8bf780ea1be9bf6.1197654480@firewall.26broadway.net> (raw)
AC_KNBCAP_DELTA is incorrectly defined as (1<<8). According to the Intel
HDA spec, this is bit 7 after AC_KNBCAP_NUM_STEPS which is a 0x7f mask.
Signed-off-by: Andrew Paprocki <andrew@ishiboo.com>
diff -r 4a204306b295 -r 3681a8bf780e pci/hda/hda_codec.h
--- a/pci/hda/hda_codec.h Fri Dec 14 14:42:41 2007 +0100
+++ b/pci/hda/hda_codec.h Fri Dec 14 12:27:35 2007 -0500
@@ -234,7 +234,7 @@ enum {
/* Volume knobs capabilities */
#define AC_KNBCAP_NUM_STEPS (0x7f<<0)
-#define AC_KNBCAP_DELTA (1<<8)
+#define AC_KNBCAP_DELTA (1<<7)
/*
* Control Parameters
next reply other threads:[~2007-12-14 20:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 16:48 Andrew Paprocki [this message]
2007-12-17 9:24 ` [PATCH] hda-codec - Fix definition of AC_KNBCAP_DELTA to match spec Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3681a8bf780ea1be9bf6.1197654480@firewall.26broadway.net \
--to=andrew@ishiboo.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox