From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arvind Yadav Subject: Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx Date: Fri, 28 Jul 2017 10:11:48 +0530 Message-ID: <36fcdba7-309b-68b0-f3e4-f2de89526af7@gmail.com> References: <20170727171338.13300-1-krzk@kernel.org> <20170727171338.13300-3-krzk@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170727171338.13300-3-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org To: Krzysztof Kozlowski , Sangbeom Kim , Sylwester Nawrocki , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org List-Id: alsa-devel@alsa-project.org Hi, On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: > The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't > probably fatal, because for SoC clocks this is usually no-op, but for > correctness this clock should be prepared. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. New patch > --- > sound/soc/samsung/s3c-i2s-v2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/samsung/s3c-i2s-v2.c b/sound/soc/samsung/s3c-i2s-v2.c > index 9b28046eea8e..3894bda06ebb 100644 > --- a/sound/soc/samsung/s3c-i2s-v2.c > +++ b/sound/soc/samsung/s3c-i2s-v2.c > @@ -637,7 +637,7 @@ int s3c_i2sv2_probe(struct snd_soc_dai *dai, > return -ENOENT; > } > > - clk_enable(i2s->iis_pclk); > + clk_prepare_enable(i2s->iis_pclk); Please, handle are return value of clk_prepare_enble. > > /* Mark ourselves as in TXRX mode so we can run through our cleanup > * process without warnings. */ ~arvind