alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Simon <horms@verge.net.au>, Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine
Date: Tue, 22 Jul 2014 03:11:52 +0200	[thread overview]
Message-ID: <3713363.Y2xICgEKrb@avalon> (raw)
In-Reply-To: <87wqb6i7wn.wl%kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Monday 21 July 2014 16:55:41 Kuninori Morimoto wrote:
> Hi Laurent
> 
> > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > 
> > > Renesas new DMAEngine driver requests src/dst_addr_width
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > 
> > > >> Laurent
> > > 
> > > Could you please check and give your Ack to this patch?
> > 
> > What tree is the patch based on ? It doesn't apply on Takashi's latest
> > master branch. I need a bit of context to review it.
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git ::
> topic/rcar
> 
> or Gerrt's driver tree

Of course :-)

I've tried to understand the driver and couldn't even find out which DMA 
controller was used :-/ I suspect it's the audio peri-peri DMAC, but I haven't 
been able to confirm that from the source code. If the assumption is true the 
patch looks OK to me, but if you need a formal Acked-by then I'll need you to 
guide me through the driver I'm afraid.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2014-07-22  1:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-17  6:18 [PATCH] ASoC: rsnd: add missing src/dst_addr_width for DMAEngine Kuninori Morimoto
2014-07-18 12:44 ` Laurent Pinchart
2014-07-21 23:55   ` Kuninori Morimoto
2014-07-22  1:11     ` Laurent Pinchart [this message]
2014-07-22  2:34       ` Kuninori Morimoto
2014-07-22 13:16         ` Laurent Pinchart
2014-07-23  0:44           ` Kuninori Morimoto
2014-07-22 13:15 ` Laurent Pinchart
2014-07-22 22:17 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3713363.Y2xICgEKrb@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).