From: "Heiko Stübner" <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>,
Chen-Yu Tsai <wenst@chromium.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Lin Huang <hl@rock-chips.com>, David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
dri-devel@lists.freedesktop.org, Sandy Huang <hjc@rock-chips.com>,
linux-rockchip@lists.infradead.org,
Mark Brown <broonie@kernel.org>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output
Date: Mon, 17 Jan 2022 09:40:54 +0100 [thread overview]
Message-ID: <3970568.xje1Q9F24u@diego> (raw)
In-Reply-To: <CAGXv+5H0-dM28YQj_orS1_14NLcJve8VtO6oLcBiRpJFjaf5KA@mail.gmail.com>
Am Montag, 17. Januar 2022, 08:44:37 CET schrieb Chen-Yu Tsai:
> On Sat, Jan 15, 2022 at 7:03 AM Brian Norris <briannorris@chromium.org> wrote:
> >
> > Commit b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> > switched the platform to SPDIF, but we didn't fix up the device tree.
> >
> > Drop the pinctrl settings, because the 'spdif_bus' pins are either:
> > * unused (on kevin, bob), so the settings is ~harmless
> > * used by a different function (on scarlet), which causes probe
> > failures (!!)
>
> I suppose that means the default pinctrl should be dropped? Or maybe this
> use case is the outlier. Up to Heiko?
Interesting question. Right now it looks like Gru is the only one using spdif
in that way, so I'd think dropping the pinctrl here is the "saner" option
at this time ;-)
I guess we can reevaluate if this becomes more widespread
> > Fixes: b18c6c3c7768 ("ASoC: rockchip: cdn-dp sound output use spdif")
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
>
next prev parent reply other threads:[~2022-01-17 8:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 23:02 [PATCH v2 0/3] (Re)enable DP/HDMI audio for RK3399 Gru Brian Norris
2022-01-14 23:02 ` [PATCH v2 1/3] arm64: dts: rockchip: Switch RK3399-Gru DP to SPDIF output Brian Norris
2022-01-17 7:44 ` Chen-Yu Tsai
2022-01-17 8:40 ` Heiko Stübner [this message]
2022-01-14 23:02 ` [PATCH v2 2/3] drm/rockchip: cdn-dp: Support HDMI codec plug-change callback Brian Norris
2022-01-17 7:45 ` Chen-Yu Tsai
2022-01-14 23:02 ` [PATCH v2 3/3] ASoC: rk3399_gru_sound: Wire up DP jack detection Brian Norris
2022-01-17 9:01 ` Chen-Yu Tsai
2022-01-18 20:17 ` Brian Norris
2022-01-19 5:59 ` Chen-Yu Tsai
2022-01-23 15:40 ` (subset) [PATCH v2 0/3] (Re)enable DP/HDMI audio for RK3399 Gru Heiko Stuebner
2022-01-28 23:46 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3970568.xje1Q9F24u@diego \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=alsa-devel@alsa-project.org \
--cc=briannorris@chromium.org \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=hl@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).