Re: Bug in pcm_lib.c ?? (using Xmms)

[Benny Sjostrand <gorm@cucumelo.org>]

>
>
>It's definitely a bug in CS46xx driver. I've changed the test for the ring 
>buffer pointer to be in range 0 .. buffer_size-1 . pointer equal to 
>buffer_size doesn't make any sense and it should be really zero.
>
>  
>
I guess I found a fix for this problem (at least the message disapears 
from the log)
in cs46xx_lib.c in snd_cs46xx_playback_indirect_pointer(...) function:


    if (bytes < 0)
        bytes += buffer_size;
    cpcm->hw_io = ptr;
    cpcm->hw_ready -= bytes;
    cpcm->sw_io += bytes;
-    if (cpcm->sw_io > cpcm->sw_bufsize)
+    if (cpcm->sw_io >= cpcm->sw_bufsize)
        cpcm->sw_io -= cpcm->sw_bufsize;
    snd_cs46xx_playback_transfer(substream, 0);

I cant hear any difference in sound quality, maybe it's just not posible 
to hear the difference ...
... and now it's too late, i'll continue tomorrow ...

/Benny



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf