Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Benny Sjöstrand" <gorm@cucumelo.org>
To: Johan Groth <jgroth@dsl.pipex.com>
Cc: alsa-devel@lists.sourceforge.net
Subject: [PATCH] Re: [Alsa-user] Hercules Gametheater XP (cs46xx)
Date: Sun, 16 Feb 2003 15:33:38 +0100	[thread overview]
Message-ID: <3E4FA142.3010406@cucumelo.org> (raw)
In-Reply-To: 3E4F8839.9070701@dsl.pipex.com

[-- Attachment #1: Type: text/plain, Size: 454 bytes --]

> Sorry, but latest CVS does not work. Sound is still very distorted. 
> CVS from 2002-12-09 12:00 works well though, which is what I'm using 
> now :) It is using version 1.37 alsa-kernel/pci/cs46xx/cs46xx_lib.cc.

Current CVS still seems to be broken. The hercules_init(...) function 
will reset the EGPIO's to default state  turning of the amplifier. This 
patch changes the initialization order calling amplifier_ctrl(...) after 
mixer_init.

/Benny

[-- Attachment #2: cs46xx.patch --]
[-- Type: text/plain, Size: 554 bytes --]

--- cs46xx_lib.c.orig	2003-02-16 15:28:21.000000000 +0100
+++ cs46xx_lib.c	2003-02-16 15:28:34.000000000 +0100
@@ -2516,9 +2516,6 @@
 	strcpy(id.name, "External Amplifier Power Down");
 	chip->eapd_switch = snd_ctl_find_id(chip->card, &id);
     
-	/* turn on amplifier */
-	chip->amplifier_ctrl(chip, 1);
-
 #ifdef CONFIG_SND_CS46XX_NEW_DSP
 	/* do soundcard specific mixer setup */
 	if (chip->mixer_init) {
@@ -2526,6 +2523,9 @@
 		chip->mixer_init(chip);
 	}
 #endif
+
+ 	/* turn on amplifier */
+	chip->amplifier_ctrl(chip, 1);
     
 	return 0;
 }

       reply	other threads:[~2003-02-16 14:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <3E4E98B5.7030409@dsl.pipex.com>
     [not found] ` <3E4EFA55.8090804@cucumelo.org>
     [not found]   ` <3E4F8839.9070701@dsl.pipex.com>
2003-02-16 14:33     ` Benny Sjöstrand [this message]
2003-02-17 10:15       ` [PATCH] Re: [Alsa-user] Hercules Gametheater XP (cs46xx) Takashi Iwai
2003-02-17 22:29         ` Christian Esken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3E4FA142.3010406@cucumelo.org \
    --to=gorm@cucumelo.org \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=jgroth@dsl.pipex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox