Re: ALC650 rev D. - SPDIF out

[James Courtier-Dutton <James@superbug.demon.co.uk>]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]

p z oooo wrote:
> Hi,
> 
> I have ALC650 rev. D and spdif is not working with 0.9.7.
> 
> Please delete this row from ac97_patch.c from function patch_alc650
> 
> ac97->ext_id &= ~AC97_EI_SPDIF; /* disable extended-id */ 
> 
> I think, that all ALC650 have spdif out and rev. E and later have 
> spdif in.
> 
> Peter Zubaj
> 
> 
The ALC650 chip specs do show that SPDIF out is present on all models.

I am not sure about your fix, because even the Realtek versions of the 
alsa driver disable spdif out if AC97_EA_SPCV is not set.
Reasons for AC97_EA_SPCV not being set are: -
Current S/PDIF configuration {SPSA,SPSR,DAC/slot rate} is invalid.

Why that only works on Rev E or above I don't know.

I think that maybe a better way would be to also remove the checking of 
AC97_EA_SPCV, and instead use the Chip revision code, now that we can 
detect chip revisions.

See attached suggested patch.

Cheers
James

[-- Attachment #2: alc650-rev-d-fix.diff --]
[-- Type: text/plain, Size: 1285 bytes --]

--- ac97_patch.c.org	2003-10-03 15:16:06.099127808 +0100
+++ ac97_patch.c	2003-10-03 15:21:50.975698600 +0100
@@ -898,7 +898,6 @@
 int patch_alc650(ac97_t * ac97)
 {
 	unsigned short val;
-	int spdif = 0;
 
 	ac97->build_ops = &patch_alc650_ops;
 
@@ -907,22 +906,16 @@
 	ac97->spec.dev_flags = (ac97->id == 0x414c4722 ||
 				ac97->id == 0x414c4723);
 
-	/* check spdif (should be only on rev.E) */
-	if (ac97->spec.dev_flags) {
-		val = snd_ac97_read(ac97, AC97_EXTENDED_STATUS);
-		if (val & AC97_EA_SPCV)
-			spdif = 1;
-	}
+	/* enable AC97_ALC650_GPIO_SETUP, AC97_ALC650_CLOCK for R/W */
+	snd_ac97_write_cache(ac97, AC97_ALC650_GPIO_STATUS, 
+		snd_ac97_read(ac97, AC97_ALC650_GPIO_STATUS) | 0x8000);
 
-	if (spdif) {
-		/* enable AC97_ALC650_GPIO_SETUP, AC97_ALC650_CLOCK for R/W */
-		snd_ac97_write_cache(ac97, AC97_ALC650_GPIO_STATUS, 
-			snd_ac97_read(ac97, AC97_ALC650_GPIO_STATUS) | 0x8000);
+	/* Enable SPDIF-IN only on Rev.E and above */
+	if (ac97->spec.dev_flags) {
 		/* enable spdif in */
 		snd_ac97_write_cache(ac97, AC97_ALC650_CLOCK,
 				     snd_ac97_read(ac97, AC97_ALC650_CLOCK) | 0x03);
-	} else
-		ac97->ext_id &= ~AC97_EI_SPDIF; /* disable extended-id */
+	} 
 
 	val = snd_ac97_read(ac97, AC97_ALC650_MULTICH);
 	val &= ~0xc000; /* slot: 3,4,7,8,6,9 */