From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>, alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org,
Clemens Ladisch <clemens@ladisch.de>,
Takashi Iwai <tiwai@suse.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()
Date: Sun, 24 Sep 2017 09:06:12 +0200 [thread overview]
Message-ID: <3afecbef-b7ac-a4e8-f439-a351916f05e5@users.sourceforge.net> (raw)
In-Reply-To: <a1dee732-f5c4-5b35-9f82-553fc8ce430d@sakamocchi.jp>
> 668 if (!amdtp_stream_wait_callback(&bebob->tx_stream,
> 669 CALLBACK_TIMEOUT)) {
> 670 amdtp_stream_stop(&bebob->tx_stream);
> 671 amdtp_stream_stop(&bebob->rx_stream);
> 672 break_both_connections(bebob);
> 673 err = -ETIMEDOUT;
> 674 }
> 675 }
>
> I think it better to apply your solution too in the above to keep code consistency.
How do you think about to adjust this function implementation after the other two
update steps from the patch series would be integrated?
> For the other patches, I can find no merit to apply except for reduction
> of the number of characters included in the file.
Would you like to refer to any specific update suggestions for further clarification?
Regards,
Markus
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2017-09-24 7:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-06 10:21 [PATCH 0/3] ALSA: BeBoB: Fine-tuning for six function implementations SF Markus Elfring
2017-09-06 10:22 ` [PATCH 1/3] ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex() SF Markus Elfring
2017-09-24 3:50 ` Takashi Sakamoto
2017-09-24 7:06 ` SF Markus Elfring [this message]
2017-09-26 23:30 ` Takashi Sakamoto
2017-09-27 6:38 ` SF Markus Elfring
2017-09-27 11:09 ` Takashi Sakamoto
2017-09-06 10:23 ` [PATCH 2/3] ALSA: bebob: Adjust six checks for null pointers SF Markus Elfring
2017-09-06 10:24 ` [PATCH 3/3] ALSA: bebob: Improve a size determination in parse_stream_formation() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3afecbef-b7ac-a4e8-f439-a351916f05e5@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).