From: Hans de Goede <hdegoede@redhat.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist
Date: Tue, 8 May 2018 09:30:53 +0200 [thread overview]
Message-ID: <3c1b30ca-b688-dfcb-3994-5d79a7ed9b96@redhat.com> (raw)
In-Reply-To: <20180508072746.10798-1-hdegoede@redhat.com>
Hi,
On 08-05-18 09:27, Hans de Goede wrote:
> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
> to the blacklist.
>
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Note I just realized this will not apply cleanly, I've 3 patches in my
local tree adding power_save quirks and I'm still waiting for feedback
on the 2 others. I did not realize this one depended on the others.
I will send out the entire series when I've test results on the
other 2 models.
Regards,
Hans
> ---
> sound/pci/hda/hda_intel.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 0981c3c64d87..9a16af179503 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2214,6 +2214,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
> SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
> /* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */
> SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0),
> + /* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
> + SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
> /* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */
> SND_PCI_QUIRK(0x17aa, 0x2227, "Lenovo X1 Carbon 3rd Gen", 0),
> {}
>
next prev parent reply other threads:[~2018-05-08 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 7:27 [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist Hans de Goede
2018-05-08 7:30 ` Hans de Goede [this message]
2018-05-13 7:09 ` Takashi Iwai
2018-05-13 7:20 ` Hans de Goede
2018-05-13 7:24 ` Takashi Iwai
2018-05-13 13:39 ` Hans de Goede
2018-05-13 14:42 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c1b30ca-b688-dfcb-3994-5d79a7ed9b96@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).