[PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Hans de Goede]

Power-saving is causing loud plops on the Lenovo C50 All in one, add it
to the blacklist.

BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 sound/pci/hda/hda_intel.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 0981c3c64d87..9a16af179503 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -2214,6 +2214,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
 	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */
 	SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0),
+	/* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
+	SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
 	/* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */
 	SND_PCI_QUIRK(0x17aa, 0x2227, "Lenovo X1 Carbon 3rd Gen", 0),
 	{}
-- 
2.17.0

Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Hans de Goede]

Hi,

On 08-05-18 09:27, Hans de Goede wrote:
> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
> to the blacklist.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Note I just realized this will not apply cleanly, I've 3 patches in my
local tree adding power_save quirks and I'm still waiting for feedback
on the 2 others. I did not realize this one depended on the others.

I will send out the entire series when I've test results on the
other 2 models.

Regards,

Hans


> ---
>   sound/pci/hda/hda_intel.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 0981c3c64d87..9a16af179503 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -2214,6 +2214,8 @@ static struct snd_pci_quirk power_save_blacklist[] = {
>   	SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0),
>   	/* https://bugzilla.kernel.org/show_bug.cgi?id=199607 */
>   	SND_PCI_QUIRK(0x8086, 0x2057, "Intel NUC5i7RYB", 0),
> +	/* https://bugzilla.redhat.com/show_bug.cgi?id=1572975 */
> +	SND_PCI_QUIRK(0x17aa, 0x36a7, "Lenovo C50 All in one", 0),
>   	/* https://bugzilla.kernel.org/show_bug.cgi?id=198611 */
>   	SND_PCI_QUIRK(0x17aa, 0x2227, "Lenovo X1 Carbon 3rd Gen", 0),
>   	{}
> 

Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Takashi Iwai]

On Tue, 08 May 2018 09:27:46 +0200,
Hans de Goede wrote:
> 
> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
> to the blacklist.
> 
> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Before adding to blacklist, could you try some usual suspects?
For Lenovo, you can try at first to pass
  model=,tpt440
to snd-hda-intel module.

(the first comma is no typo but to pass the model name to the second
 controller for Realtek.)

The above will add some bogus dock jacks, so it's no solution but to
just to test whether it avoids the clicking noise.


thanks,

Takashi

Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Hans de Goede]

Hi Takashi,

On 05/13/2018 09:09 AM, Takashi Iwai wrote:
> On Tue, 08 May 2018 09:27:46 +0200,
> Hans de Goede wrote:
>>
>> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
>> to the blacklist.
>>
>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Before adding to blacklist, could you try some usual suspects?
> For Lenovo, you can try at first to pass
>    model=,tpt440
> to snd-hda-intel module.
> 
> (the first comma is no typo but to pass the model name to the second
>   controller for Realtek.)
> 
> The above will add some bogus dock jacks, so it's no solution but to
> just to test whether it avoids the clicking noise.

Sure, note I'm just forwarding these bugs from Fedora reporters,
more often then not I don't have access to the hardware myself.

I always add a BugLink tag to the bug, so perhaps next time you
can reach out to the reporter directly ? I've forwarded your
request this time.

I also always ask for alsa-info.sh output, so following the BugLink
will also give you access to that.

Regards,

Hans

Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Takashi Iwai]

On Sun, 13 May 2018 09:20:10 +0200,
Hans de Goede wrote:
> 
> Hi Takashi,
> 
> On 05/13/2018 09:09 AM, Takashi Iwai wrote:
> > On Tue, 08 May 2018 09:27:46 +0200,
> > Hans de Goede wrote:
> >>
> >> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
> >> to the blacklist.
> >>
> >> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
> >> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Before adding to blacklist, could you try some usual suspects?
> > For Lenovo, you can try at first to pass
> >    model=,tpt440
> > to snd-hda-intel module.
> >
> > (the first comma is no typo but to pass the model name to the second
> >   controller for Realtek.)
> >
> > The above will add some bogus dock jacks, so it's no solution but to
> > just to test whether it avoids the clicking noise.
> 
> Sure, note I'm just forwarding these bugs from Fedora reporters,
> more often then not I don't have access to the hardware myself.
> 
> I always add a BugLink tag to the bug, so perhaps next time you
> can reach out to the reporter directly ? I've forwarded your
> request this time.

Heh, I'd need to create a fedora bugzilla account at first ;-)
But will try at the next time.

At this time, I'm currently processing the pending stuff during my
vacation in the last week, so in anyway, it'd be great if you can let
people testing in your side.

> I also always ask for alsa-info.sh output, so following the BugLink
> will also give you access to that.

Yes, alsa-info.sh output helps really a lot for debugging, thanks for
asking it!


Takashi

Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Hans de Goede]

Hi,

On 05/13/2018 08:20 AM, Hans de Goede wrote:
> Hi Takashi,
> 
> On 05/13/2018 09:09 AM, Takashi Iwai wrote:
>> On Tue, 08 May 2018 09:27:46 +0200,
>> Hans de Goede wrote:
>>>
>>> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
>>> to the blacklist.
>>>
>>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>
>> Before adding to blacklist, could you try some usual suspects?
>> For Lenovo, you can try at first to pass
>>    model=,tpt440
>> to snd-hda-intel module.
>>
>> (the first comma is no typo but to pass the model name to the second
>>   controller for Realtek.)
>>
>> The above will add some bogus dock jacks, so it's no solution but to
>> just to test whether it avoids the clicking noise.
> 
> Sure, note I'm just forwarding these bugs from Fedora reporters,
> more often then not I don't have access to the hardware myself.
> 
> I always add a BugLink tag to the bug, so perhaps next time you
> can reach out to the reporter directly ? I've forwarded your
> request this time.
> 
> I also always ask for alsa-info.sh output, so following the BugLink
> will also give you access to that.

So the user just replied:

"Still hear loud pops with 4.16.7-300.fc28.x86_64 using
snd_hda_intel.model=,tpt440 (confirmed enabled in sysfs).

I think in some sense this is just 'poppy' hardware -- it's always emitted a
pop (though not as loud as these) when the sound card is initialised, even
under Windows."

Regards,

Hans
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

Re: [PATCH] ALSA: hda: Add Lenovo C50 All in one to the power_save blacklist

[Takashi Iwai]

On Sun, 13 May 2018 15:39:35 +0200,
Hans de Goede wrote:
> 
> Hi,
> 
> On 05/13/2018 08:20 AM, Hans de Goede wrote:
> > Hi Takashi,
> >
> > On 05/13/2018 09:09 AM, Takashi Iwai wrote:
> >> On Tue, 08 May 2018 09:27:46 +0200,
> >> Hans de Goede wrote:
> >>>
> >>> Power-saving is causing loud plops on the Lenovo C50 All in one, add it
> >>> to the blacklist.
> >>>
> >>> BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1572975
> >>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >>
> >> Before adding to blacklist, could you try some usual suspects?
> >> For Lenovo, you can try at first to pass
> >>    model=,tpt440
> >> to snd-hda-intel module.
> >>
> >> (the first comma is no typo but to pass the model name to the second
> >>   controller for Realtek.)
> >>
> >> The above will add some bogus dock jacks, so it's no solution but to
> >> just to test whether it avoids the clicking noise.
> >
> > Sure, note I'm just forwarding these bugs from Fedora reporters,
> > more often then not I don't have access to the hardware myself.
> >
> > I always add a BugLink tag to the bug, so perhaps next time you
> > can reach out to the reporter directly ? I've forwarded your
> > request this time.
> >
> > I also always ask for alsa-info.sh output, so following the BugLink
> > will also give you access to that.
> 
> So the user just replied:
> 
> "Still hear loud pops with 4.16.7-300.fc28.x86_64 using
> snd_hda_intel.model=,tpt440 (confirmed enabled in sysfs).
> 
> I think in some sense this is just 'poppy' hardware -- it's always emitted a
> pop (though not as loud as these) when the sound card is initialised, even
> under Windows."

OK, then let's add to the blacklist.  Thanks for quick testing and
information!


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel