Re: [PATCH linux-next] ASOC: SOF: use devm_kcalloc() instead of devm_kzalloc()

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 9/16/22 08:25, cgel.zte@gmail.com wrote:
> From: ye xingchen <ye.xingchen@zte.com.cn>
> 
> Use 2-factor multiplication argument form devm_kcalloc() instead
> of devm_kzalloc().
> 
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>

Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

> ---
>  sound/soc/sof/nocodec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/soc/sof/nocodec.c b/sound/soc/sof/nocodec.c
> index 356497fe4f4c..3537805070ad 100644
> --- a/sound/soc/sof/nocodec.c
> +++ b/sound/soc/sof/nocodec.c
> @@ -32,7 +32,7 @@ static int sof_nocodec_bes_setup(struct device *dev,
>  
>  	/* set up BE dai_links */
>  	for (i = 0; i < link_num; i++) {
> -		dlc = devm_kzalloc(dev, 3 * sizeof(*dlc), GFP_KERNEL);
> +		dlc = devm_kcalloc(dev, 3, sizeof(*dlc), GFP_KERNEL);
>  		if (!dlc)
>  			return -ENOMEM;
>  
> @@ -78,7 +78,7 @@ static int sof_nocodec_setup(struct device *dev,
>  	struct snd_soc_dai_link *links;
>  
>  	/* create dummy BE dai_links */
> -	links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_dai_drivers, GFP_KERNEL);
> +	links = devm_kcalloc(dev, num_dai_drivers, sizeof(struct snd_soc_dai_link), GFP_KERNEL);
>  	if (!links)
>  		return -ENOMEM;
>