From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, rohitkr@codeaurora.org,
linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
swboyd@chromium.org, judyhsiao@chromium.org
Cc: Venkata Prasad Potturu <potturu@codeaurora.org>
Subject: Re: [PATCH 2/7] ASoC: qcom: dt-bindings: Add compatible names for lpass sc7280 digital codecs
Date: Tue, 21 Sep 2021 12:29:08 +0530 [thread overview]
Message-ID: <3e8ea5bd-9301-2605-b7e9-02ddab076fc7@codeaurora.org> (raw)
In-Reply-To: <7c12126d-99a8-4572-6e95-b63131cae300@linaro.org>
On 9/20/2021 6:54 PM, Srinivas Kandagatla wrote:
Thanks for your time Srini!!
>
> On 20/09/2021 08:35, Srinivasa Rao Mandadapu wrote:
>> Update compatible names in va, wsa, rx and tx macro codes for lpass
>> sc7280
>>
>> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org>
>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml | 4
>> +++-
>> Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml | 4
>> +++-
>> Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml | 4
>> +++-
>> Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml | 4
>> +++-
>> 4 files changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
>> b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
>> index 443d556..a4e767e 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>> properties:
>> compatible:
>> - const: qcom,sm8250-lpass-rx-macro
>> + oneOf:
>> + - const: qcom,sm8250-lpass-rx-macro
>> + - const: qcom,sc7280-lpass-rx-macro
> Recently Rob did tree wide change to use enum instead of oneOf for
> below reason
> "
> 'enum' is equivalent to 'oneOf' with a list of 'const' entries, but
> 'enum' is more concise and yields better error messages."
>
> So, can you move these to enums like:
>
> enum:
> - qcom,sm8250-lpass-rx-macro
> - qcom,sc7280-lpass-rx-macro
>
> --srini
Okay. will change accordingly and post it.
>
>> reg:
>> maxItems: 1
>> diff --git
>> a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
>> b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
>> index 6b5ca02..cdec478 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>> properties:
>> compatible:
>> - const: qcom,sm8250-lpass-tx-macro
>> + oneOf:
>> + - const: qcom,sm8250-lpass-tx-macro
>> + - const: qcom,sc7280-lpass-tx-macro
>> reg:
>> maxItems: 1
>> diff --git
>> a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> index 679b49c..e15bc05 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>> properties:
>> compatible:
>> - const: qcom,sm8250-lpass-va-macro
>> + oneOf:
>> + - const: qcom,sm8250-lpass-va-macro
>> + - const: qcom,sc7280-lpass-va-macro
>> reg:
>> maxItems: 1
>> diff --git
>> a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> index 435b019..2dcccb5 100644
>> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
>> @@ -11,7 +11,9 @@ maintainers:
>> properties:
>> compatible:
>> - const: qcom,sm8250-lpass-wsa-macro
>> + oneOf:
>> + - const: qcom,sm8250-lpass-wsa-macro
>> + - const: qcom,sc7280-lpass-wsa-macro
>> reg:
>> maxItems: 1
>>
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2021-09-21 7:00 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 7:35 [PATCH 0/7] Update Lpass digital codec macro drivers Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 1/7] ASoC: qcom: Add compatible names in va, wsa, rx, tx codec drivers for sc7280 Srinivasa Rao Mandadapu
2021-09-20 18:17 ` [PATCH 1/7] ASoC: qcom: Add compatible names in va,wsa,rx,tx " Stephen Boyd
2021-09-21 8:42 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 2/7] ASoC: qcom: dt-bindings: Add compatible names for lpass sc7280 digital codecs Srinivasa Rao Mandadapu
2021-09-20 13:24 ` Srinivas Kandagatla
2021-09-21 6:59 ` Srinivasa Rao Mandadapu [this message]
2021-09-20 7:35 ` [PATCH 3/7] ASoC: codecs: tx-macro: Change mic control registers to volatile Srinivasa Rao Mandadapu
2021-09-20 13:24 ` Srinivas Kandagatla
2021-09-21 7:30 ` Srinivasa Rao Mandadapu
2021-09-21 8:48 ` Srinivas Kandagatla
2021-09-21 13:02 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 4/7] ASoC: codecs: lpass-va-macro: Change bulk voting to individual clock voting Srinivasa Rao Mandadapu
2021-09-20 13:25 ` Srinivas Kandagatla
2021-09-21 8:14 ` Srinivasa Rao Mandadapu
2021-09-21 8:50 ` Srinivas Kandagatla
2021-09-21 12:25 ` Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 5/7] ASoC: codecs: lpass-rx-macro: " Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 6/7] ASoC: codecs: lpass-tx-macro: " Srinivasa Rao Mandadapu
2021-09-20 7:35 ` [PATCH 7/7] ASoC: codecs: lpass-va-macro: set mclk clock rate correctly Srinivasa Rao Mandadapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e8ea5bd-9301-2605-b7e9-02ddab076fc7@codeaurora.org \
--to=srivasam@codeaurora.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=judyhsiao@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=potturu@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=swboyd@chromium.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).