From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1FFC4C001DB for ; Mon, 7 Aug 2023 15:00:03 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 31A6F823; Mon, 7 Aug 2023 16:59:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 31A6F823 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1691420400; bh=SUHQAeoPZgXBUwMl+B0ovX2ZyA2nHmqJqeRcETZsoR0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=XuL2X+Zsz+kbOnfcUH3T5dkKBNlWtNx9wJ5Y0pMyFwQb+pd6SUOMc30sGr9y+vPuE V5wQyLr3HgL3lERtaFXHGCv6eHDm6AFPmtabvKsDUQytG3cX6s/YTf3WUnDOQ9r4GO mYtsCo6US0xpgms3QZSL26vn60OK9LfBr5vBRiW0= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 99981F805CB; Mon, 7 Aug 2023 16:57:09 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3D849F805C1; Mon, 7 Aug 2023 16:57:09 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 036BAF80570; Mon, 7 Aug 2023 16:56:57 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9F04DF80553; Mon, 7 Aug 2023 16:56:50 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9F04DF80553 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=aNsBNDWX DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691420213; x=1722956213; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=SUHQAeoPZgXBUwMl+B0ovX2ZyA2nHmqJqeRcETZsoR0=; b=aNsBNDWXcVh3VltuXqx/HwgSUn2Tqcg48DERV4E+S+ipHWqWdBfcHCLt BWUH8yu5BP08OrtTmsFqCvldH4Jr430VUf5zpMsY2ugVrPiV+nR948xAF eAS+sSALv9vwg+L2YADwW3azKyQdrMP+0mZlLuRn1rgxZV4uDMsh94Fnb fMXgF7DWSOwC/2I99TWe8xzkwUr1AuT6c14yQKjeBt5OV93BLKUY2D6ks /ibQMHPlH6sSt8DSaKaOvCR/XwKmIS0oklADbIWkngpA/JwdUVI9rl9nB fKFLwExNfD00EV1boN6QDV0jy9GmUX+4zegmNZtqbidvwbr7B278iYiKM A==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="434410645" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="434410645" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:56:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="1061623896" X-IronPort-AV: E=Sophos;i="6.01,262,1684825200"; d="scan'208";a="1061623896" Received: from hweelee-mobl.amr.corp.intel.com (HELO [10.209.181.215]) ([10.209.181.215]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Aug 2023 07:56:44 -0700 Message-ID: <401de8fb-8d33-d699-ba09-a7b90356d915@linux.intel.com> Date: Mon, 7 Aug 2023 09:28:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH v3 9/9] ALSA: hda/i915: Remove extra argument from snd_hdac_i915_init Content-Language: en-US To: Maarten Lankhorst , alsa-devel@alsa-project.org Cc: Maarten Lankhorst , Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20230807090045.198993-1-maarten.lankhorst@linux.intel.com> <20230807090045.198993-10-maarten.lankhorst@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: <20230807090045.198993-10-maarten.lankhorst@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Message-ID-Hash: O72CFINSW34Y5BYQBQ3GLOWNHHFE5CFE X-Message-ID-Hash: O72CFINSW34Y5BYQBQ3GLOWNHHFE5CFE X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: <> List-Archive: <> List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > @@ -172,18 +172,10 @@ int snd_hdac_i915_init(struct hdac_bus *bus, bool allow_modprobe) > acomp = bus->audio_component; > if (!acomp) > return -ENODEV; > - if (allow_modprobe && !acomp->ops) { > - if (!IS_ENABLED(CONFIG_MODULES) || > - !request_module("i915")) { > - /* 60s timeout */ > - wait_for_completion_killable_timeout(&acomp->master_bind_complete, > - msecs_to_jiffies(60 * 1000)); heads-up that I have a conflicting patch to make the 60s delay configurable, see https://github.com/thesofproject/linux/pull/4505 > - } > - } > if (!acomp->ops) { > - int err = allow_modprobe ? -ENODEV : -EPROBE_DEFER; > snd_hdac_acomp_exit(bus); > - return dev_err_probe(bus->dev, err, "couldn't bind with audio component\n"); > + return dev_err_probe(bus->dev, -EPROBE_DEFER, > + "couldn't bind with audio component\n"); > } > return 0; > }