From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76188C433E0 for ; Wed, 8 Jul 2020 16:19:29 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F38B920786 for ; Wed, 8 Jul 2020 16:19:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="fJ/wk0Ab" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F38B920786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=siol.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 308A81660; Wed, 8 Jul 2020 18:18:36 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 308A81660 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1594225166; bh=vjXbKcKdkAFsmiJJiEZ7tBeW92sorwzPcgqtTPI1nVc=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fJ/wk0Abm85k1/Hp6r/VRclfdmyBdde7czzZHj6m+5P0PqgvuqS4Qx8N6+Y0GiRfA RibAccbMz6AH5Hoo8pJkK+C2Gz8VFTa+VMj06G8pfY5U/ZGiCnPNf7S2Esvb/n9KDS 2MhRChXgQ8O8ZPXQGphtd7OnjEx4qmJlzjP0viBg= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id BF1F5F802BC; Wed, 8 Jul 2020 18:18:12 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 298DCF802BD; Wed, 8 Jul 2020 18:18:11 +0200 (CEST) Received: from mail.siol.net (mailoutvs16.siol.net [185.57.226.207]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9FADFF802A9 for ; Wed, 8 Jul 2020 18:17:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9FADFF802A9 Received: from localhost (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTP id 4A96C524C57; Wed, 8 Jul 2020 18:17:58 +0200 (CEST) X-Virus-Scanned: amavisd-new at psrvmta10.zcs-production.pri Received: from mail.siol.net ([127.0.0.1]) by localhost (psrvmta10.zcs-production.pri [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id oLEpCQVAM4I0; Wed, 8 Jul 2020 18:17:57 +0200 (CEST) Received: from mail.siol.net (localhost [127.0.0.1]) by mail.siol.net (Postfix) with ESMTPS id D452E524C76; Wed, 8 Jul 2020 18:17:57 +0200 (CEST) Received: from jernej-laptop.localnet (cpe-194-152-20-232.static.triera.net [194.152.20.232]) (Authenticated sender: jernej.skrabec@siol.net) by mail.siol.net (Postfix) with ESMTPA id 47E03524BD7; Wed, 8 Jul 2020 18:17:57 +0200 (CEST) From: Jernej =?utf-8?B?xaBrcmFiZWM=?= To: =?ISO-8859-1?Q?Cl=E9ment_P=E9ron?= , Maxime Ripard Subject: Re: [PATCH 08/16] arm64: dts: allwinner: h6: Add HDMI audio node Date: Wed, 08 Jul 2020 18:17:57 +0200 Message-ID: <4073007.RJdR9ZcIkj@jernej-laptop> In-Reply-To: <20200706052937.ygjjllrsj7rvynkq@gilmour.lan> References: <20200704113902.336911-1-peron.clem@gmail.com> <20200704113902.336911-9-peron.clem@gmail.com> <20200706052937.ygjjllrsj7rvynkq@gilmour.lan> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , linux-sunxi@googlegroups.com, Takashi Iwai , Marcus Cooper , Chen-Yu Tsai , Rob Herring , linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi! Dne ponedeljek, 06. julij 2020 ob 07:29:37 CEST je Maxime Ripard napisal(a): > Hi, >=20 > On Sat, Jul 04, 2020 at 01:38:54PM +0200, Cl=E9ment P=E9ron wrote: > > From: Jernej Skrabec > >=20 > > Add a simple-soundcard to link audio between HDMI and I2S. > >=20 > > Signed-off-by: Jernej Skrabec > > Signed-off-by: Marcus Cooper > > Signed-off-by: Cl=E9ment P=E9ron > > --- > >=20 > > arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 33 ++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > >=20 > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi index > > 78b1361dfbb9..ae169d07b939 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi > > @@ -67,6 +67,25 @@ de: display-engine { > >=20 > > status =3D "disabled"; > > =09 > > }; > >=20 > > + hdmi_sound: hdmi-sound { > > + compatible =3D "simple-audio-card"; > > + simple-audio-card,format =3D "i2s"; > > + simple-audio-card,name =3D "sun50i-h6-hdmi"; > > + simple-audio-card,mclk-fs =3D <128>; > > + simple-audio-card,frame-inversion; >=20 > Have you figured that one out? >=20 > > + status =3D "disabled"; > > + > > + simple-audio-card,codec { > > + sound-dai =3D <&hdmi>; > > + }; > > + > > + simple-audio-card,cpu { > > + sound-dai =3D <&i2s1>; > > + dai-tdm-slot-num =3D <2>; > > + dai-tdm-slot-width =3D <32>; >=20 > I'm not sure why you need to use the TDM stuff here. IIRC the HDMI > controller can output on up to 6 channels, so how would that work out? dai-tdm-slot-width is needed to override automatic slot width selection. It= =20 should always be 32 for HDMI, no matter what is actual physical sample widt= h.=20 In this case this property is abused to set width also for I2S mode of=20 operation. IMO there is no sense to duplicate code because I2S variant woul= d=20 work exactly the same, except name would be different. I'm not sure about dai-tdm-slot-num. Marcus, can you explain the need for t= his=20 property? Would it be better to implement separate link driver instead of using simpl= e- card to hide all this properties into the code? Best regards, Jernej