From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D62FC4332B for ; Fri, 20 Mar 2020 17:58:54 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BF84B20663 for ; Fri, 20 Mar 2020 17:58:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="K6T7t1UT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF84B20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 206A874C; Fri, 20 Mar 2020 18:58:02 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 206A874C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584727132; bh=mgdsGABw+34WOSLS+9+KFL3Fn8vFhUt5AokHKm0t94c=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=K6T7t1UTPDzMNFQ28JgtIi/v2p9VelofDHKe6qCJS8lF/RoAvx/9Ofo70ch2eCko7 uBm+MTFMlS0gZYAbK6ZfA7L7vqk8jU6cRcap4c7ENvKKPipwbnHLDzb1Tp+2AG70Nc DKQMf9ML45+RPIJOAP7ryypsq9S1+wcg4tefvQWE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 68536F80126; Fri, 20 Mar 2020 18:58:01 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9CE4AF8015B; Fri, 20 Mar 2020 18:57:59 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9F4CBF800C0 for ; Fri, 20 Mar 2020 18:57:55 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9F4CBF800C0 IronPort-SDR: au+8JKT2ArkikSH3jxPlOJ+chmv+09dikwZ4wa0gl0jjYuqzwzmzGG9d1mwOoNKHbX/k1rI9oJ 6FMjdT5bql6Q== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2020 10:57:53 -0700 IronPort-SDR: OmDXVhyTKlU50WoWzpmVCqcLA7WUwVpCf1Ao7u1nBnBGKJ/i2veDk5SXC5PBRgALl8UdNfmn1Z JPTfAOqQ1bEQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,285,1580803200"; d="scan'208";a="392225793" Received: from manallet-mobl.amr.corp.intel.com (HELO [10.255.34.12]) ([10.255.34.12]) by orsmga004.jf.intel.com with ESMTP; 20 Mar 2020 10:57:50 -0700 Subject: Re: [PATCH 5/5] soundwire: qcom: add sdw_master_device support To: Srinivas Kandagatla , alsa-devel@alsa-project.org References: <20200320162947.17663-1-pierre-louis.bossart@linux.intel.com> <20200320162947.17663-6-pierre-louis.bossart@linux.intel.com> <81e2101e-d7ce-d023-5c35-ac6b55ea7166@linaro.org> From: Pierre-Louis Bossart Message-ID: <40803069-e7dc-3dd6-ec7b-bec4308f381e@linux.intel.com> Date: Fri, 20 Mar 2020 12:57:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <81e2101e-d7ce-d023-5c35-ac6b55ea7166@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , Hui Wang , vkoul@kernel.org, broonie@kernel.org, Andy Gross , jank@cadence.com, "open list:ARM/QUALCOMM SUPPORT" , slawomir.blauciak@intel.com, Sanyog Kale , Bjorn Andersson , Bard liao , Rander Wang X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> Add new device as a child of the platform device, following the >> following hierarchy: >> >> platform_device >>      sdw_master_device >>          sdw_slave0 > > Why can't we just remove the platform device layer here and add > sdw_master_device directly? > > What is it stopping doing that? The guidance from Greg was "no platform devices, unless you really are on a platform bus (i.e. Device tree.)". We never discussed changing the way the Device Tree parts are handled. The main idea was to leave the parent (be it platform-device or PCI device) alone and not add new attributes or references to it. The scheme here is similar to I2C/SPI, you have a platform device handled by the Device Tree baseline, and a driver create an i2c_adapter/spi_controller/sdw_master_device.