Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Rebe <rene.rebe@gmx.net>
To: alsa-devel@lists.sourceforge.net
Subject: [PATCH] pmac also apply the DMA stop work around to fix capture on iBook2
Date: Fri, 30 Jul 2004 16:56:29 +0200	[thread overview]
Message-ID: <410A619D.6010102@gmx.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

Hi all,

the attached patch for the pmac driver fixes capture for at least all 
iBook2s I have access to. Without the fix arround 33% percent of all 
recordings are just white noise.

Have fun,
  René Rebe

[-- Attachment #2: alsa-pmac2.patch --]
[-- Type: text/plain, Size: 992 bytes --]

--- ppc/pmac.c~	2004-07-30 14:14:36.643095880 +0200
+++ ppc/pmac.c	2004-07-30 14:16:47.039272648 +0200
@@ -224,15 +224,15 @@
 	/* We really want to execute a DMA stop command, after the AWACS
 	 * is initialized.
 	 * For reasons I don't understand, it stops the hissing noise
-	 * common to many PowerBook G3 systems (like mine :-).
+	 * common to many PowerBook G3 systems and random noise otherwise
+	 * captured on iBook2's about every third time. -ReneR
 	 */
 	spin_lock_irq(&chip->reg_lock);
 	snd_pmac_dma_stop(rec);
-	if (rec->stream == SNDRV_PCM_STREAM_PLAYBACK) {
-		st_le16(&chip->extra_dma.cmds->command, DBDMA_STOP);
-		snd_pmac_dma_set_command(rec, &chip->extra_dma);
-		snd_pmac_dma_run(rec, RUN);
-	}
+	st_le16(&chip->extra_dma.cmds->command, DBDMA_STOP);
+	snd_pmac_dma_set_command(rec, &chip->extra_dma);
+	snd_pmac_dma_run(rec, RUN);
+	mdelay(5);
 	/* continuous DMA memory type doesn't provide the physical address,
 	 * so we need to resolve the address here...
 	 */



             reply	other threads:[~2004-07-30 14:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-30 14:56 Rene Rebe [this message]
2004-08-02 11:46 ` [PATCH] pmac also apply the DMA stop work around to fix capture on iBook2 Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410A619D.6010102@gmx.net \
    --to=rene.rebe@gmx.net \
    --cc=alsa-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox