From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD083C77B7D for ; Thu, 18 May 2023 05:46:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 96CE6201; Thu, 18 May 2023 07:45:24 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 96CE6201 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1684388774; bh=/izmuKyWTHVjqYqkjbciuWjyQO/u2ZyGMKARkrpgv1I=; h=From:To:CC:Subject:Date:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=tCk2wqY2pAF+ScdTVUFVoGEmJmD0O9kKiEMpVfxsYzlI0P3Ko1wh6PsFGaeElp5Xg JG6ntXSiwndh85VT2TSA9cGVPb9dB3mtktLcXN9Mckq4zcsmHXK/l95xexu5mnEyNq ZBDgiRDu2q84SLwv+Dkcvg6oR+nCyB9VNVvGObBA= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C3148F8053D; Thu, 18 May 2023 07:44:49 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 3FE34F80272; Thu, 18 May 2023 07:44:49 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6E90BF80272; Thu, 18 May 2023 07:44:43 +0200 (CEST) Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id AFE20F8016A for ; Thu, 18 May 2023 07:44:31 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz AFE20F8016A Authenticated-By: X-SpamFilter-By: ArmorX SpamTrap 5.77 with qID 34I5iEWN1001346, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.81/5.90) with ESMTPS id 34I5iEWN1001346 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=OK); Thu, 18 May 2023 13:44:14 +0800 Received: from RTEXMBS06.realtek.com.tw (172.21.6.99) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 18 May 2023 13:44:23 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXMBS06.realtek.com.tw (172.21.6.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Thu, 18 May 2023 13:44:23 +0800 Received: from RTEXMBS01.realtek.com.tw ([fe80::4d7:e49a:674a:598]) by RTEXMBS01.realtek.com.tw ([fe80::4d7:e49a:674a:598%5]) with mapi id 15.01.2375.007; Thu, 18 May 2023 13:44:23 +0800 From: Kailang To: Takashi Iwai , "Joseph C. Sible" CC: Bagas Sanjaya , "regressions@lists.linux.dev" , "perex@perex.cz" , "tiwai@suse.com" , "alsa-devel@alsa-project.org" Subject: RE: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot Thread-Topic: Fwd: [Bug 217440] New: ALC236 audio disappears from HP 15z-fc000 on warm boot Thread-Index: AQHZhdSOD7kY6mXBDkGA3ryhp811r69Yu5SAgAASNACAAA22gIAA7n+AgAEJrYCABLe/YA== Date: Thu, 18 May 2023 05:44:23 +0000 Message-ID: <415d4bc84aa74c74af913048f28b42a9@realtek.com> References: <87cz338ix4.wl-tiwai@suse.de> <874jodlnmi.wl-tiwai@suse.de> In-Reply-To: <874jodlnmi.wl-tiwai@suse.de> Accept-Language: zh-TW, en-US Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.22.102.106] x-kse-serverinfo: RTEXMBS06.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback Message-ID-Hash: 4GEGDPG3NTJNE2YL4KGLFNPVXFRO2HEV X-Message-ID-Hash: 4GEGDPG3NTJNE2YL4KGLFNPVXFRO2HEV X-MailFrom: kailang@realtek.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > -----Original Message----- > From: Takashi Iwai > Sent: Monday, May 15, 2023 9:40 PM > To: Joseph C. Sible > Cc: Bagas Sanjaya ; regressions@lists.linux.dev; > Kailang ; perex@perex.cz; tiwai@suse.com; > alsa-devel@alsa-project.org > Subject: Re: Fwd: [Bug 217440] New: ALC236 audio disappears from HP > 15z-fc000 on warm boot >=20 >=20 > External mail. >=20 >=20 >=20 > On Sun, 14 May 2023 23:48:55 +0200, > Joseph C. Sible wrote: > > > > On 5/14/23, Takashi Iwai wrote: > > > The patch changes two places (the change in alc_shutup_pins() and > > > alc256_shutup()), and I guess the latter is the culprit. Could you > > > verify that only reverting the latter fixes the problem? > > > > Yes, only reverting the latter fixes the problem. I just tried a > > kernel consisting of 6.3.2 plus the below change, and it works fine: > > > > --- a/sound/pci/hda/patch_realtek.c > > +++ b/sound/pci/hda/patch_realtek.c > > @@ -3638,8 +3638,7 @@ static void alc256_shutup(struct hda_codec > *codec) > > /* If disable 3k pulldown control for alc257, the Mic > > detection will not work correctly > > * when booting with headset plugged. So skip setting it for > > the codec alc257 > > */ > > - if (codec->core.vendor_id !=3D 0x10ec0236 && > > - codec->core.vendor_id !=3D 0x10ec0257) > > + if (codec->core.vendor_id !=3D 0x10ec0257) > > alc_update_coef_idx(codec, 0x46, 0, 3 << 12); > > > > if (!spec->no_shutup_pins) >=20 > OK, thanks for confirmation. >=20 > Kailang, could you check this issue? OK. I will take it a look for these days. > Judging from the comment there: >=20 > /* 3k pull low control for Headset jack. */ > /* NOTE: call this before clearing the pin, otherwise codec stall= s */ > /* If disable 3k pulldown control for alc257, the Mic detection w= ill > not work correctly > * when booting with headset plugged. So skip setting it for the > codec alc257 > */ >=20 > ... it seems that the codec got screwed with this setup, which leaded to = the > non-response at the probe after reboot. >=20 > In the worst case, I'll revert that part. >=20 >=20 > thanks, >=20 > Takashi >=20 > ------Please consider the environment before printing this e-mail.