From: Ed Wildgoose <lists@wildgooses.com>
To: tiwai@suse.de, alsa-devel@lists.sourceforge.net
Subject: Re: patch: RME9632 precise_ptr fix (9652 owners please read)
Date: Thu, 11 Nov 2004 12:50:56 +0000 [thread overview]
Message-ID: <41936030.2050205@wildgooses.com> (raw)
In-Reply-To: <4163FCCA.1090909@wildgooses.com>
Hi Takashi,
I was just checking the hdsp driver code for a new kernel build and I
notice that my patch was committed incorrectly. Notice that the
"position /= 4;" line has been removed inadvertently in that commit:
http://cvs.sourceforge.net/viewcvs.py/alsa/alsa-kernel/pci/rme9652/hdsp.c?r1=1.71&r2=1.72
See below for original patch as sent to the list:
Summary: Fix accurate_ptr in hdsp driver
Signoff: Ed Wildgoose (lists (at) wildgooses.com)
Thanks
Ed W
> --- hdsp.c.orig 2004-10-06 14:58:37.052866070 +0100
> +++ hdsp.c 2004-10-06 14:59:15.034213752 +0100
> @@ -969,8 +969,7 @@
>
> position &= HDSP_BufferPositionMask;
> position /= 4;
> - position -= 32;
> - position &= (HDSP_CHANNEL_BUFFER_SAMPLES-1);
> + position &= ((hdsp->period_bytes/2)-1);
> return position;
> }
-------------------------------------------------------
This SF.Net email is sponsored by:
Sybase ASE Linux Express Edition - download now for FREE
LinuxWorld Reader's Choice Award Winner for best database on Linux.
http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click
next prev parent reply other threads:[~2004-11-11 12:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-06 14:10 patch: RME9632 precise_ptr fix (9652 owners please read) Ed Wildgoose
2004-10-07 12:53 ` Takashi Iwai
2004-10-08 22:05 ` Ed Wildgoose
2004-10-11 10:29 ` Takashi Iwai
2004-11-11 12:50 ` Ed Wildgoose [this message]
2004-11-15 19:07 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41936030.2050205@wildgooses.com \
--to=lists@wildgooses.com \
--cc=alsa-devel@lists.sourceforge.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox