From: "Shuming [范書銘]" <shumingf@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"lars@metafoo.de" <lars@metafoo.de>,
"Flove(HsinFu)" <flove@realtek.com>,
"Oder Chiou" <oder_chiou@realtek.com>,
"Jack Yu" <jack.yu@realtek.com>,
"Derek [方德義]" <derek.fang@realtek.com>,
"Vijendar.Mukunda@amd.com" <Vijendar.Mukunda@amd.com>
Subject: RE: [PATCH 2/2] ASoC: rt1316: fix key tone missing
Date: Fri, 21 Jul 2023 15:34:37 +0000 [thread overview]
Message-ID: <423480b14c6c4a7ab4d9bfcf8b29cccb@realtek.com> (raw)
In-Reply-To: <3f407d2e-fe11-4ad1-8fb3-561053d343a9@sirena.org.uk>
> > From: Shuming Fan <shumingf@realtek.com>
> >
> > This patch disables the soft ramp to output immediately.
>
> > { 0xc09d, 0x80 },
> > { 0xc0b0, 0x77 },
> > - { 0xc010, 0xa5 },
> > + { 0xc010, 0x25 },
> > { 0xc050, 0x83 },
>
> This should probably be an actual control not something patched into the
> registers - some users might prefer toe soft ramp.
Got it. I will add a mixer control for it. Thanks.
> ------Please consider the environment before printing this e-mail.
prev parent reply other threads:[~2023-07-21 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 8:18 [PATCH 2/2] ASoC: rt1316: fix key tone missing shumingf
2023-07-21 11:18 ` Mark Brown
2023-07-21 15:34 ` Shuming [范書銘] [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=423480b14c6c4a7ab4d9bfcf8b29cccb@realtek.com \
--to=shumingf@realtek.com \
--cc=Vijendar.Mukunda@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox