From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pierre-Louis Bossart Subject: Re: [alsa-devel] [PATCH] ASoC: Intel: bytcr_5640.c:Refactored if statement and removed buffer Date: Mon, 6 May 2019 10:21:56 -0500 Message-ID: <423c7b83-abd6-4f75-ad3a-7c650b76e8bb@linux.intel.com> References: <20190504151652.5213-1-user@elitebook-localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190504151652.5213-1-user@elitebook-localhost> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Nariman , linux-kernel@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.com, yang.jie@linux.intel.com, liam.r.girdwood@linux.intel.com, hdegoede@redhat.com, broonie@kernel.org List-Id: alsa-devel@alsa-project.org > static int byt_rt5640_suspend(struct snd_soc_card *card) > @@ -1268,28 +1266,12 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) > log_quirks(&pdev->dev); > > if ((byt_rt5640_quirk & BYT_RT5640_SSP2_AIF2) || > - (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) { > - > - /* fixup codec aif name */ > - snprintf(byt_rt5640_codec_aif_name, > - sizeof(byt_rt5640_codec_aif_name), > - "%s", "rt5640-aif2"); > - > - byt_rt5640_dais[dai_index].codec_dai_name = > - byt_rt5640_codec_aif_name; > - } > + (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) > + byt_rt5640_dais[dai_index].codec_dai_name = "rt5640-aif2"; This is not equivalent, you don't deal with the (byt_rt5640_quirk & BYT_RT5640_SSP2_AIF2) case. The default is SSP_AIF1 > > if ((byt_rt5640_quirk & BYT_RT5640_SSP0_AIF1) || > - (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) { > - > - /* fixup cpu dai name name */ > - snprintf(byt_rt5640_cpu_dai_name, > - sizeof(byt_rt5640_cpu_dai_name), > - "%s", "ssp0-port"); > - > - byt_rt5640_dais[dai_index].cpu_dai_name = > - byt_rt5640_cpu_dai_name; > - } > + (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) > + byt_rt5640_dais[dai_index].cpu_dai_name = "ssp0-port"; Same here, this is not equivalent. the SSP0_AIF1 case is not handled. it's fine to remove the intermediate buffers, but you can't remove support for 2 out of the 4 combinations supported.