Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Stransky <stransky@redhat.com>
To: Lee Revell <rlrevell@joe-job.com>
Cc: Alsa-Devel <alsa-devel@lists.sourceforge.net>
Subject: Re: alsa-lib patches
Date: Mon, 02 May 2005 09:43:23 +0200	[thread overview]
Message-ID: <4275DA1B.7080902@redhat.com> (raw)
In-Reply-To: <1114796778.21730.12.camel@mindpipe>

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Bugzilla link:

https://bugzilla.redhat.com/bugzilla-old/show_bug.cgi?id=146607

We had old patch (it's attached) and it's very similar to your current 
code. It causes some problems, so i changed the patch and it works.

Ma.

> Please give a more detailed description of the patches.  What kind of
> problem?  How about a bugzilla link?
> 
> Lee

[-- Attachment #2: old-alsa-lib-stack.patch --]
[-- Type: text/x-patch, Size: 851 bytes --]

--- alsa-lib-1.0.6/src/mixer/mixer.c.org	2005-01-07 22:37:42.688153791 +0100
+++ alsa-lib-1.0.6/src/mixer/mixer.c	2005-01-07 22:39:49.943579453 +0100
@@ -520,17 +520,14 @@
 	return c1->class->compare(c1, c2);
 }
 
+typedef int (*qsort_func)(const void *, const void *);
 static int snd_mixer_sort(snd_mixer_t *mixer)
 {
 	unsigned int k;
-	int compar(const void *a, const void *b) {
-		return mixer->compare(*(const snd_mixer_elem_t * const *) a,
-				      *(const snd_mixer_elem_t * const *) b);
-	}
 	assert(mixer);
 	assert(mixer->compare);
 	INIT_LIST_HEAD(&mixer->elems);
-	qsort(mixer->pelems, mixer->count, sizeof(snd_mixer_elem_t*), compar);
+	qsort(mixer->pelems, mixer->count, sizeof(snd_mixer_elem_t*), (qsort_func)mixer->compare);
 	for (k = 0; k < mixer->count; k++)
 		list_add_tail(&mixer->pelems[k]->list, &mixer->elems);
 	return 0;

  reply	other threads:[~2005-05-02  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-04-29 13:57 alsa-lib patches Martin Stransky
2005-04-29 17:46 ` Lee Revell
2005-05-02  7:43   ` Martin Stransky [this message]
2005-05-02  8:43 ` Clemens Ladisch
  -- strict thread matches above, loose matches on Subject: below --
2005-05-15 14:57 Kevin F.Quinn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4275DA1B.7080902@redhat.com \
    --to=stransky@redhat.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=rlrevell@joe-job.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox