Re: [Openvortex-dev] Re: [ALSA - driver 0001138]: errors when installing au8820 modules

Raymond
2005-06-12T15:18:10Z

Igor Kovalenko wrote:
> Raymond wrote:
>
>>Takashi Iwai wrote:
>>>Raymond wrote:
>>>>Is there any reason to make this change ?
>>>>
>>>>alsa-kernel/pci/au88x0/au88x0.c
>>>>@@ -144,15 +144,18 @@
>>>> // check PCI availability (DMA).
>>>> if ((err = pci_enable_device(pci)) < 0)
>>>> return err;
>>>>- if (!pci_dma_supported(pci, VORTEX_DMA_MASK)) {
>>>>+ if (pci_set_dma_mask(pci, VORTEX_DMA_MASK) < 0 ||
>>>>+ pci_set_consistent_dma_mask(pci, VORTEX_DMA_MASK) < 0) {
>>>> printk(KERN_ERR "error to set DMA mask\n");
>>>>+ pci_disable_device(pci);
>>>> return -ENXIO;
>>>> }
>>>>- pci_set_dma_mask(pci, VORTEX_DMA_MASK);
>>>
>>>
>>>
>>>This is clean up.
>>>
>>>
>>>
>>>> chip = kcalloc(1, sizeof(*chip), GFP_KERNEL);
>>>>- if (chip == NULL)
>>>>+ if (chip == NULL) {
>>>>+ pci_disable_device(pci);
>>>> return -ENOMEM;
>>>>+ }
>>>
>>>
>>>
>>>This fixes the PCI state in the error path.
>>>
>>>
>>>
>>>> chip->card = card;
>>>>
>>>>@@ -202,6 +205,8 @@
>>>> goto alloc_out;
>>>> }
>>>>
>>>>+ snd_card_set_dev(card, &pci->dev);
>>>>+
>>>> *rchip = chip;
>>>
>>>
>>>
>>>And this sets up the missing sysfs stuff.
>>>
>>>
>>
>>So these changes are not neccesary(critical) for
>>au88x0_64_bits_compatible.patch (AMD64 and X86_64 ) , just normal ALSA
>>cleanup.
>>
>
>
> Actually without snd_card_set_dev() you will get oops shortly because device
> pointer won't be available to driver.
> DMA mask cleanup is to follow general guidelines about consistent mapping.
>

This patch (ALSA 1.0.2c, Kernel 2.6) had been posted on the
openvortex-devel mailing list since Feb, 2004.

http://lists.nongnu.org/archive/html/openvortex-dev/2004-02/msg00010.html

Does it mean that 32bits machines will also get oops on Kernel 2.6 ?

Any unresolved bugs in ALSA BTS are related to the missing of
"snd_card_set_dev(card, &pci->dev);" ?

-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20