Re: Re: [ALSA - driver 0001138]: errors when installing au8820 modules

Alien
2005-06-07T15:16:02Z

[-- Attachment #1: Type: text/plain, Size: 1792 bytes --]

Op dinsdag 7 juni 2005 17:05, schreef Raymond:
> The patch (diff11.diff) cause segmenation fault on my 32bit machine
> during /etc/init.d/alsasound start
>
> http://savannah.nongnu.org/patch/?func=detailitem&item_id=3948
>
> Do anyone know why readl() and writel() behave different in i386
> (32bits) and AMD64 (64bits) ?
>
> http://sourceforge.net/mailarchive/message.php?msg_id=10773530
>
>
> #ifndef CONFIG_X86_64
>
> #define hwread(x,y) readl((x)+((y)>>2))
> #define hwwrite(x,y,z) writel((z),(x)+((y)>>2))
>
> #else
>
> #define hwread(x,y) readl((x)+(y))
> #define hwwrite(x,y,z) writel((z),(x)+(y))
>
> #endif

that doesn't look good, unless the mmio is void* in 32bit and unsigned long*
in x86_64...

'unsigned long* mmio' should be preferred and together with '#define
hwread(x,y) readl((x)+(y))' , this works for both platforms

> Takashi Iwai wrote:
> > At Mon, 06 Jun 2005 10:09:26 +0800,
> >
> > Raymond wrote:
> >>The au88x0 driver need patch to run on 64-bits platform.
> >>
> >>http://savannah.nongnu.org/patch/?func=detailitem&item_id=3948
> >
> > Could you feed the patch to alsa-devel ML for review?
> > (The addition of Signed-off-by would be preferred, too)
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: NEC IT Guy Games. How far can you
> shotput a projector? How fast can you ride your desk chair down the office
> luge track? If you want to score the big prize, get to know the little guy.
> Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]