From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CE03C433EF for ; Mon, 27 Sep 2021 11:01:53 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E389B60F41 for ; Mon, 27 Sep 2021 11:01:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E389B60F41 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D22031685; Mon, 27 Sep 2021 13:00:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D22031685 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1632740509; bh=Iaf/IR4SFyg/tk/cm26SEoC9bidGQcxlRdgMQcEyO44=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pGQJ6XZGxWCvLcbXcYbuSsAgp0w70B2kpP+FeDuZSaL4NJqkQXKPADzPWUNRZwQki maKkcjtTUpjOcdn/Zg7bxv8yKv6qg6qX4nIP+3QRLap8ZEygpwxlLIMRemy1AwK9tk Y1O0gbw9gPdWaYhm+1v/UaIBYIiokvkQ9rWhD9E0= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 66F52F801EC; Mon, 27 Sep 2021 13:00:59 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 720EAF80227; Mon, 27 Sep 2021 13:00:56 +0200 (CEST) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 28345F801EC for ; Mon, 27 Sep 2021 13:00:48 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 28345F801EC Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="NhQBnKK7" Received: by mail-wm1-x331.google.com with SMTP id v127so113124wme.5 for ; Mon, 27 Sep 2021 04:00:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XRPjobKyc5ikQATTaoAB7Ef8aUh+iksQjqZVpv1jq0M=; b=NhQBnKK7mtJZsLT0zSi+otuLrck7DozDRVmMoSvgzMD93dzVcJOKzGYhZxIjH4Me/7 0Du+8TL/5Zv7xbbGINbEKEr3BlW2T1WtrKDtIxtHwrCWrT1kTf2fvkY0Lkw5Ix/m7wLD qgi7LDb45wt2PtYD7GCfsz2zurrBUaZRZnv7e74kb/1JkfaST+mzzlaFg9qNniw/NEg3 uo3VJkpdIImegi8yjsYhVZbQ+dlKIUEH0N1PclJgtSxmKM3IS3DjqGmB8gHutPGAPfoP n+mmVrXB5N6PXNTlSz1wjhNfKwdx/7GK1+CvLRehLUY0ETXlI16Ufwcl5Rs+GX+f1b7F FtJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XRPjobKyc5ikQATTaoAB7Ef8aUh+iksQjqZVpv1jq0M=; b=J7S/pRJky7dIP8ukb4PXdhV6HdqmgvVR/lac+F+/cyRKQBCggoWL3uvBURX4dP2Zqc LhxPsEVhkJJArPJC8I34fQ9yIV2Bj2vCeL7DGUV/WB12xJz0OHByWceKxjUvBxj7zUdG sgZFLMH/ghOg78eGCMIeNUXhLz2tX1o5UL6XxsMP1DsQT6DE0Gn2W8p0B6fo2kkW7cS5 5Nz/yyNzqZfkEnuFjaQTr/Fj6WPsH+RpoPM/uALkWSiIsSpDUYRkGi88gjD0ZBo1D7bN fai1LmiKqkw96adX9WjkRJI/XNSavg/hNfX7pjI9LQlQb491DiV/PmcSfPKLnZiVb1oQ IOdg== X-Gm-Message-State: AOAM531R+sWdL8xB00TTy+OH5A1zke8qHaKc8vjzO048ehsMgpKxnVpm 0duhDxmiRZYRBWhMpNZOfv5YEA== X-Google-Smtp-Source: ABdhPJxdLf3oTwzJd3Le+/Za8FBBJicKwqsOBTFqoxg/0i9px3fsuAJIV0kgo6XJ5xIUB6tdqPE/4A== X-Received: by 2002:a05:600c:aca:: with SMTP id c10mr15023179wmr.174.1632740447259; Mon, 27 Sep 2021 04:00:47 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id j14sm16114810wrp.21.2021.09.27.04.00.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 27 Sep 2021 04:00:46 -0700 (PDT) Subject: Re: [PATCH] ASoC: wcd9335: Use correct version to initialize Class H To: Yassine Oudjana , Banajit Goswami , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai References: <20210925022339.786296-1-y.oudjana@protonmail.com> From: Srinivas Kandagatla Message-ID: <43d70ca3-bd14-c83a-12df-8cd64056256a@linaro.org> Date: Mon, 27 Sep 2021 12:00:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210925022339.786296-1-y.oudjana@protonmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 25/09/2021 03:24, Yassine Oudjana wrote: > The versioning scheme was changed in an earlier patch, which caused the version > being used to initialize WCD9335 to be interpreted as if it was WCD937X, which > changed code paths causing broken headphones output. Pass WCD9335 instead of > WCD9335_VERSION_2_0 to wcd_clsh_ctrl_alloc to fix it. > > Fixes: 19c5d1f6a0c3 ("ASoC: codecs: wcd-clsh: add new version support") > Signed-off-by: Yassine Oudjana > --- Thanks for the fix, LGTM, Reviewed-by: Srinivas Kandagatla --srini > sound/soc/codecs/wcd9335.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/codecs/wcd9335.c b/sound/soc/codecs/wcd9335.c > index d885ced34f60..bc5d68c53e5a 100644 > --- a/sound/soc/codecs/wcd9335.c > +++ b/sound/soc/codecs/wcd9335.c > @@ -4859,7 +4859,7 @@ static int wcd9335_codec_probe(struct snd_soc_component *component) > > snd_soc_component_init_regmap(component, wcd->regmap); > /* Class-H Init*/ > - wcd->clsh_ctrl = wcd_clsh_ctrl_alloc(component, wcd->version); > + wcd->clsh_ctrl = wcd_clsh_ctrl_alloc(component, WCD9335); > if (IS_ERR(wcd->clsh_ctrl)) > return PTR_ERR(wcd->clsh_ctrl); > >