From: Pierre Ossman <ossman@cendio.se>
To: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org
Subject: [PATCH] Incorrect revents in polypaudio plugin
Date: Tue, 07 Mar 2006 18:19:24 +0100 [thread overview]
Message-ID: <440DC09C.5080102@cendio.se> (raw)
[-- Attachment #1: Type: text/plain, Size: 183 bytes --]
The revent flags POLLIN/POLLOUT got switched in the Polypaudio plugin.
Most applications check both so it went unnoticed until now.
Signed-off-by: Pierre Ossman <ossman@cendio.se>
[-- Attachment #2: alsa-plugins-switch-polls.patch --]
[-- Type: text/x-patch, Size: 588 bytes --]
Index: polyp/pcm_polyp.c
===================================================================
RCS file: /cvsroot/alsa/alsa-plugins/polyp/pcm_polyp.c,v
retrieving revision 1.2
diff -u -r1.2 pcm_polyp.c
--- polyp/pcm_polyp.c 22 Feb 2006 15:38:52 -0000 1.2
+++ polyp/pcm_polyp.c 7 Mar 2006 17:17:43 -0000
@@ -314,9 +314,9 @@
*/
if (pcm->last_size >= pcm->buffer_attr.minreq) {
if (io->stream == SND_PCM_STREAM_PLAYBACK)
- *revents |= POLLIN;
- else
*revents |= POLLOUT;
+ else
+ *revents |= POLLIN;
}
return 0;
next reply other threads:[~2006-03-07 17:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-07 17:19 Pierre Ossman [this message]
2006-03-08 12:22 ` [PATCH] Incorrect revents in polypaudio plugin Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=440DC09C.5080102@cendio.se \
--to=ossman@cendio.se \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox