From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: broonie@kernel.org, alsa-devel@alsa-project.org,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
tiwai@suse.com
Subject: Re: [alsa-devel] [PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support
Date: Thu, 6 Jun 2019 14:29:45 +0100 [thread overview]
Message-ID: <446dd43c-c47e-c7a3-bcef-33241f41e4b0@linaro.org> (raw)
In-Reply-To: <20190606152402.2d310b7d@xxx>
On 06/06/2019 14:24, Amadeusz Sławiński wrote:
>> + SOC_SINGLE_SX_TLV("IIR1 INP1 Volume",
>> LPASS_CDC_IIR1_GAIN_B1_CTL,
>> + 0, -84, 40, digital_gain),
>> + SOC_SINGLE_SX_TLV("IIR1 INP2 Volume",
>> LPASS_CDC_IIR1_GAIN_B2_CTL,
>> + 0, -84, 40, digital_gain),
>> + SOC_SINGLE_SX_TLV("IIR1 INP3 Volume",
>> LPASS_CDC_IIR1_GAIN_B3_CTL,
>> + 0, -84, 40, digital_gain),
>> + SOC_SINGLE_SX_TLV("IIR1 INP4 Volume",
>> LPASS_CDC_IIR1_GAIN_B4_CTL,
>> + 0, -84, 40, digital_gain),
> There seems to be some alignment issue in above line.
> And while I'm commenting this place, there is only 4 Volume controls,
> while there is 5 switches for IIR1 and IIR2, is this right?
>
Each IIR Filter is 5 Stage, and IIR block is feed with 4 inputs, these
volumes above refers to each input path.
Thanks,
srini
>> + SOC_SINGLE_SX_TLV("IIR2 INP1 Volume",
>> LPASS_CDC_IIR2_GAIN_B1_CTL,
next prev parent reply other threads:[~2019-06-06 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 12:42 [PATCH v2] ASoC: msm8916-wcd-digital: Add sidetone support Srinivas Kandagatla
2019-06-06 13:24 ` [alsa-devel] " Amadeusz Sławiński
2019-06-06 13:29 ` Srinivas Kandagatla [this message]
2019-06-07 12:27 ` Applied "ASoC: msm8916-wcd-digital: Add sidetone support" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446dd43c-c47e-c7a3-bcef-33241f41e4b0@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).